Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] helpdesk_mgmt #638

Open
wants to merge 405 commits into
base: 17.0
Choose a base branch
from
Open

Conversation

giarve
Copy link

@giarve giarve commented Oct 11, 2024

If original author is not available, superseeding #529

anybody wants to create a new icon for 17.0 style? some svg you could use https://www.svgrepo.com/svg/378347/system-help

Copy link

@imlopes imlopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work ;)

@giarve
Copy link
Author

giarve commented Oct 24, 2024

@pedrobaeza should I rebase hard on latest 16.0 branch to remove this pandoc stuff from here? I read somewhere that's what you recommended, but I do not know if it is a must.

@pedrobaeza pedrobaeza mentioned this pull request Oct 25, 2024
@pedrobaeza
Copy link
Member

Do a interactive rebase over 17.0 (not 16.0), and edit the pre-commit commit, removing the .deb, and the continue the rebasing.

@giarve giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch 3 times, most recently from 6167dc0 to 9db2f9e Compare October 26, 2024 19:45
MiquelRForgeFlow and others added 19 commits October 26, 2024 21:51
Currently translated at 100.0% (211 of 211 strings)

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/
The way it worked until the change was that these fields were populated with the customer's information when the ticket was created.
And to preserve that functionality I think it is necessary to keep informing those fields when creating the ticket from the portal.
Because when creating the ticket from the back-end the behavior is similar, when selecting a customer, the fields are filled automatically.
Currently translated at 76.3% (161 of 211 strings)

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/tr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/
Currently translated at 100.0% (212 of 212 strings)

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/
Currently translated at 100.0% (216 of 216 strings)

Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/
This helps to really prioritize tickets as they will show on
the top of the list or kanban.

It is also more aligned with standard project tasks.
Currently translated at 97.6% (249 of 255 strings)

Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/es/
Currently translated at 100.0% (255 of 255 strings)

Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/pt/
Currently translated at 100.0% (255 of 255 strings)

Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/it/
Currently translated at 100.0% (255 of 255 strings)

Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/it/
Currently translated at 100.0% (255 of 255 strings)

Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/sv/
Currently translated at 47.0% (120 of 255 strings)

Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt
Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/ca/
@giarve giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch from 9db2f9e to 6ee31ef Compare October 26, 2024 19:53
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@imlopes
Copy link

imlopes commented Nov 5, 2024

@pedrobaeza it's ok for merge this PR ?
Thanks

@pedrobaeza
Copy link
Member

/ocabot migration helpdesk_mgmt

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 5, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 5, 2024
5 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing all the XML-IDs? That is only making difficult the migration of all the rest of the dependent modules, and some of the changes are incorrect.

For example, for views, it's correct to start the XML-ID saying the model (view), then an identifier, and finish with the type of view (for example, _form). Putting view at the end is what is incorrect.

@imlopes
Copy link

imlopes commented Nov 5, 2024

Why are you changing all the XML-IDs? That is only making difficult the migration of all the rest of the dependent modules, and some of the changes are incorrect.

For example, for views, it's correct to start the XML-ID saying the model (view), then an identifier, and finish with the type of view (for example, _form). Putting view at the end is what is incorrect.

@pedrobaeza can you give an example ?
I checked and on the previous version with have the _view at the end :

<record id="helpdesk_ticket_kanban_view" model="ir.ui.view">

But on this PR, we have the view type :
https://github.com/OCA/helpdesk/pull/638/files#diff-346c30f602ec791c5cec98db55dd28a4446400acb877323ee25536e72eaa4924R3

Am I missing something ?

@pedrobaeza
Copy link
Member

Just look the diff of the migration commit:

imagen

Even if the previous XML-ID was not correct (which is more than the new one IMO), changing them arbitrarily is not good for avoiding errors or more work on dependent modules.

@imlopes
Copy link

imlopes commented Nov 5, 2024

Ahh I got it.
You're right.

@giarve giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch 2 times, most recently from 220b4c4 to d1e4683 Compare November 8, 2024 11:01
Co-authored-by: Chandni Prajapati Khamar <[email protected]>
@giarve giarve force-pushed the wvbs/17.0-mig-helpdesk_mgmt branch from d1e4683 to 3b9adc8 Compare November 8, 2024 11:15
@giarve
Copy link
Author

giarve commented Nov 8, 2024

yep. Demo XML-ids are okay to change I imagine? as they do not affect migrations. Otherwise there are some problems with tests and we can use this PR to suffix them according to the OCA guidelines at this point.

the rest of xml-ids are indeed unnecesary to change. they were in the original PR and now I went one by one reverting the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.