-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] helpdesk_mgmt #638
base: 17.0
Are you sure you want to change the base?
Conversation
f6b2819
to
bcc60ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this work ;)
@pedrobaeza should I rebase hard on latest 16.0 branch to remove this pandoc stuff from here? I read somewhere that's what you recommended, but I do not know if it is a must. |
Do a interactive rebase over 17.0 (not 16.0), and edit the pre-commit commit, removing the .deb, and the continue the rebasing. |
6167dc0
to
9db2f9e
Compare
Currently translated at 100.0% (211 of 211 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/
The way it worked until the change was that these fields were populated with the customer's information when the ticket was created. And to preserve that functionality I think it is necessary to keep informing those fields when creating the ticket from the portal. Because when creating the ticket from the back-end the behavior is similar, when selecting a customer, the fields are filled automatically.
Currently translated at 76.3% (161 of 211 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/tr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/
Currently translated at 100.0% (212 of 212 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/
Currently translated at 100.0% (216 of 216 strings) Translation: helpdesk-15.0/helpdesk-15.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-15-0/helpdesk-15-0-helpdesk_mgmt/es_AR/
This helps to really prioritize tickets as they will show on the top of the list or kanban. It is also more aligned with standard project tasks.
Currently translated at 97.6% (249 of 255 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/es/
Currently translated at 100.0% (255 of 255 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/pt/
Currently translated at 100.0% (255 of 255 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/it/
Currently translated at 100.0% (255 of 255 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/it/
Currently translated at 100.0% (255 of 255 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/sv/
Currently translated at 47.0% (120 of 255 strings) Translation: helpdesk-16.0/helpdesk-16.0-helpdesk_mgmt Translate-URL: https://translation.odoo-community.org/projects/helpdesk-16-0/helpdesk-16-0-helpdesk_mgmt/ca/
9db2f9e
to
6ee31ef
Compare
This PR has the |
@pedrobaeza it's ok for merge this PR ? |
/ocabot migration helpdesk_mgmt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you changing all the XML-IDs? That is only making difficult the migration of all the rest of the dependent modules, and some of the changes are incorrect.
For example, for views, it's correct to start the XML-ID saying the model (view
), then an identifier, and finish with the type of view (for example, _form
). Putting view
at the end is what is incorrect.
@pedrobaeza can you give an example ?
But on this PR, we have the view type : Am I missing something ? |
Ahh I got it. |
220b4c4
to
d1e4683
Compare
Co-authored-by: Chandni Prajapati Khamar <[email protected]>
d1e4683
to
3b9adc8
Compare
yep. Demo XML-ids are okay to change I imagine? as they do not affect migrations. Otherwise there are some problems with tests and we can use this PR to suffix them according to the OCA guidelines at this point. the rest of xml-ids are indeed unnecesary to change. they were in the original PR and now I went one by one reverting the changes. |
If original author is not available, superseeding #529
anybody wants to create a new icon for 17.0 style? some svg you could use https://www.svgrepo.com/svg/378347/system-help