Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intel compile to Intel2022 #571
Update intel compile to Intel2022 #571
Changes from 68 commits
9efbe3b
556e3e3
437b189
da439e1
9e88613
1359145
362c767
437d6fb
3fcb166
caf22c0
f5d200d
8c2ead4
619ecd8
6dca839
aa42971
d8f09b5
b6d8af0
6383ae7
59b9e26
f5b0b23
facd50f
d134822
5d4cf66
bac7531
4fb0a04
b601e59
9434673
f01cca6
aace46e
f842350
db70960
56a22ca
ea336c6
e5d89c3
06772e5
3bf5e01
1fe104e
ff26a62
fe42c85
a7a6a2e
3baf6c7
d3fe9a2
7bd5f95
e50cf96
a0e48e2
4864e07
1d8beed
e2398c7
164126b
8d6009b
29a1bb6
c077a1c
44feb8a
ffba673
3d47231
06ad860
d0fdffc
fb580f1
1e819ea
1ccf38d
e9b24d6
04a4336
e4fc198
91ca898
06ed4d7
f4524b9
1485b20
5edbe26
7cb76d8
047001b
dc96296
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this
prepend_path
point at the official installation all UFS and EMC apps should use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others should also confirm but the
MODULEPATH
s I see in this PR jive with the ones that ufs-weather-model moved to (ufs-community/ufs-weather-model#1465) and which global-workflow and other components are also moving to. The ufs-weather-model issue I refer to has a nice listing at the top of the various machine installs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated prepend_path and module versions all come from ufs-weather-model develop for Hera, Jet, and Orion.
I did not change setup for other machines because I cannot access them. But the ufs-weather-model develop still use intel 19 for wcoss2, which should be updated for both model and GSI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's work with g-w and others to update as many modulefiles as possible. Tagging @KateFriedman-NOAA , natalie-perlin, and @GeorgeVandenberghe-NOAA , and [email protected]. Should anyone be removed from this list? Should anyone be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all of the (fully) supported R&D platforms are covered in this PR (Hera, Orion, Jet). @DavidHuber-NOAA is providing updates for S4 (low support). WCOSS2 is not considered in this PR since it's only intel 2019 still and not EPIC-maintained hpc-stacks. Will update WCOSS2 to intel 2022 at a later date (likely when we move to spack-stack but not 100% on that). Updates in this PR should not break WCOSS2 functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. GSI
develop
must use officially approved and maintained modules. It would be good to get confirmation from EMC g-w and library staff that this PR brings in the correct modules and versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paths look correct. A couple versions are ahead of where workflow is (and not in UFS), but we can update to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this resolved, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If GSI paths are ahead of g-w, will
gsi.x
andenkf.x
run correctly in g-w?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be resolved in the g-w. I linked this discussion into the relevant issue NOAA-EMC/global-workflow#812. I believe this conversation can be resolved.