-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intel compile to Intel2022 #571
Merged
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
9efbe3b
Merge pull request #1 from NOAA-EMC/master
DavidHuber-NOAA 556e3e3
Merge branch 'NOAA-EMC:master' into master
DavidHuber-NOAA 437b189
Merge branch 'NOAA-EMC:develop' into master
DavidHuber-NOAA da439e1
fix several bugs found when uses 2022.01 intel compiler.
hu5970 9e88613
Merge remote-tracking branch 'upstream/develop' into HEAD
hu5970 1359145
Update Hera Intel compiler to intel 2022.01.
hu5970 362c767
Update intel compile for Jet and Orion for using intel 2022.1
hu5970 437d6fb
Update S4 module, remove TODO. #447
DavidHuber-NOAA 3fcb166
Merge pull request #6 from DavidHuber-NOAA/intel2022_dh
hu5970 caf22c0
Merge branch 'NOAA-EMC:develop' into master
DavidHuber-NOAA f5d200d
Fix out of bounds ref and cleanup. #447
DavidHuber-NOAA 8c2ead4
Fixed out of bounds and vector assignment bugs #471
DavidHuber-NOAA 619ecd8
Merge pull request #7 from DavidHuber-NOAA/intel2022_dh
hu5970 6dca839
Decrease radar memory footprint. #471
DavidHuber-NOAA aa42971
Removed duplicate call to read_hdraob #471
DavidHuber-NOAA d8f09b5
Merge remote-tracking branch 'ming/intel2022' into intel2022_dh
b6d8af0
Merge remote-tracking branch 'emc/develop' into intel2022_dh
6383ae7
Fix out of bounds error, trim system calls, optimize do loop #447
59b9e26
Revert to Fortran-created directories. Move metadata screening to ncd…
DavidHuber-NOAA f5b0b23
Let one PE create directories #447
facd50f
Merge remote-tracking branch 'emc/develop' into intel2022_dh
d134822
Add ncdiag v1.1.0, update Cheyenne Intel location. #447
5d4cf66
Merge pull request #8 from DavidHuber-NOAA/intel2022_dh
hu5970 bac7531
Updated ncdiag version in ci/spack.yaml #447
4fb0a04
Merge remote-tracking branch 'emc/develop' into intel2022_dh
b601e59
Stop if allocations fail. #571
9434673
Merge pull request #9 from DavidHuber-NOAA/intel2022_dh
hu5970 f01cca6
Gaea modulefile update, fix files location update on Jet,Hera,Orion,G…
aace46e
Gaea modulefile update
f842350
Merge remote-tracking branch 'upstream/develop' into intel2022_dh
db70960
Merge remote-tracking branch 'ming/intel2022' into intel2022_dh
56a22ca
Fixed directory creation. #571
ea336c6
Reverted regression_var.sh.
e5d89c3
Update Gaea and Cheyenne modulefiles.
06772e5
Merge pull request #10 from DavidHuber-NOAA/intel2022_dh
hu5970 3bf5e01
Modulefile for Gaea and regression tests configuration
1fe104e
Merge branch 'intel2022_gaea' into gaea_intel2022
natalie-perlin ff26a62
Merge pull request #1 from natalie-perlin/gaea_intel2022
natalie-perlin fe42c85
Intel 2022 for Gaea,update tests scripts for Gaea, Cheyenne, Orion, Jet
a7a6a2e
Merge branch 'intel2022_gaea' of github.com:natalie-perlin/GSI into i…
3baf6c7
update Cheyenne modulefile
d3fe9a2
updatesto scripts to address comments
7bd5f95
update regression/regression_driver.sh
e50cf96
update regression/regression_driver.sh
a0e48e2
update ush/build.sh
4864e07
Merge remote-tracking branch 'ming/intel2022' into intel2022_gaea
1d8beed
fixed typ inmodulefile for gaea
e2398c7
ncdiag/1.1.1 for spack build
164126b
update ncdiag/1.1.1
8d6009b
gaea modulefile update
29a1bb6
updated test scripts for gaea
c077a1c
Merge pull request #11 from natalie-perlin/intel2022_gaea
hu5970 44feb8a
update hera.gnu modulefile to use epic hpc-stack, load ncdiag from ma…
RussTreadon-NOAA ffba673
Merge branch 'NOAA-EMC:develop' into intel2022
RussTreadon-NOAA 3d47231
remove w3nco from gsi_common.lua and gsi_cheyenne.gnu.lua
RussTreadon-NOAA 06ad860
Merge pull request #12 from RussTreadon-NOAA/intel2022
hu5970 d0fdffc
update gsi_wcoss2.lua to ncdiag/1.1.1 and nemsio/2.5.4, update gnu co…
RussTreadon-NOAA fb580f1
Remove labels to fix RT on Orion and Jet #447 (#14)
DavidHuber-NOAA 1e819ea
Update Orion stack location for the new role-epic account (#15)
natalie-perlin 1ccf38d
Merge branch 'NOAA-EMC:develop' into intel2022
RussTreadon-NOAA e9b24d6
Added a new chadmin template to detect_machine.sh #595 (#16)
DavidHuber-NOAA 04a4336
Merge branch 'develop' into intel2022
RussTreadon-NOAA e4fc198
use sub-communicator for parallel netcdf io in gsi_rfv3io_mod.f90 (#447)
RussTreadon-NOAA 91ca898
modifications for acorn (wcoss2 test system) build using intel19 spac…
RussTreadon-NOAA 06ed4d7
add version numbers to module loads in gsi_common_wcoss2.lua (#447)
RussTreadon-NOAA f4524b9
Merge branch 'develop' into intel2022
RussTreadon-NOAA 1485b20
revert gsi_wcoss2.lua to develop (#447)
RussTreadon-NOAA 5edbe26
Merge branch 'NOAA-EMC:develop' into intel2022
RussTreadon-NOAA 7cb76d8
update nemsio version in spack.yaml, clean up sub_wcoss2 (#447)
RussTreadon-NOAA 047001b
remove gsi_common_wcoss2.lua since no longer used (#447)
RussTreadon-NOAA dc96296
generalize machine specific sub scripts to allow different modulefile…
RussTreadon-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,11 +15,11 @@ spack: | |
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected].2 | ||
- [email protected].4 | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- gsi-ncdiag@1.0.0 | ||
- gsi-ncdiag@1.1.1 | ||
view: true | ||
concretizer: | ||
unify: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
help([[ | ||
]]) | ||
|
||
load("cmake/3.20.1") | ||
|
||
prepend_path("MODULEPATH","/lustre/f2/dev/role.epic/contrib/hpc-stack/intel-classic-2022.0.2/modulefiles/stack") | ||
load(pathJoin("hpc", os.getenv("hpc_ver") or "1.2.0")) | ||
|
||
load(pathJoin("intel-classic", os.getenv("intel_classic_ver") or "2022.0.2")) | ||
load(pathJoin("cray-mpich", os.getenv("cray_mpich_ver") or "7.7.20")) | ||
load(pathJoin("hpc-intel-classic", os.getenv("hpc_intel_classic_ver") or "2022.0.2")) | ||
load(pathJoin("hpc-cray-mpich", os.getenv("hpc_cray_mpich_ver") or "7.7.20")) | ||
|
||
load("gsi_common") | ||
|
||
local prod_util_ver=os.getenv("prod_util_ver") or "1.2.2" | ||
load(pathJoin("prod_util", prod_util_ver)) | ||
|
||
-- Needed at runtime: | ||
load("alps") | ||
|
||
local MKLROOT="/opt/intel/oneapi/mkl/2022.0.2/" | ||
prepend_path("LD_LIBRARY_PATH",pathJoin(MKLROOT,"lib/intel64")) | ||
pushenv("MKLROOT", MKLROOT) | ||
|
||
pushenv("GSI_BINARY_SOURCE_DIR", "/lustre/f2/dev/role.epic/contrib/GSI_data/fix/20230601") | ||
|
||
setenv("CC","cc") | ||
setenv("FC","ftn") | ||
setenv("CXX","CC") | ||
pushenv("CRAYPE_LINK_TYPE","dynamic") | ||
|
||
whatis("Description: GSI environment on Gaea with Intel Compilers") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this
prepend_path
point at the official installation all UFS and EMC apps should use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others should also confirm but the
MODULEPATH
s I see in this PR jive with the ones that ufs-weather-model moved to (ufs-community/ufs-weather-model#1465) and which global-workflow and other components are also moving to. The ufs-weather-model issue I refer to has a nice listing at the top of the various machine installs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated prepend_path and module versions all come from ufs-weather-model develop for Hera, Jet, and Orion.
I did not change setup for other machines because I cannot access them. But the ufs-weather-model develop still use intel 19 for wcoss2, which should be updated for both model and GSI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's work with g-w and others to update as many modulefiles as possible. Tagging @KateFriedman-NOAA , natalie-perlin, and @GeorgeVandenberghe-NOAA , and [email protected]. Should anyone be removed from this list? Should anyone be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all of the (fully) supported R&D platforms are covered in this PR (Hera, Orion, Jet). @DavidHuber-NOAA is providing updates for S4 (low support). WCOSS2 is not considered in this PR since it's only intel 2019 still and not EPIC-maintained hpc-stacks. Will update WCOSS2 to intel 2022 at a later date (likely when we move to spack-stack but not 100% on that). Updates in this PR should not break WCOSS2 functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. GSI
develop
must use officially approved and maintained modules. It would be good to get confirmation from EMC g-w and library staff that this PR brings in the correct modules and versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paths look correct. A couple versions are ahead of where workflow is (and not in UFS), but we can update to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this resolved, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If GSI paths are ahead of g-w, will
gsi.x
andenkf.x
run correctly in g-w?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be resolved in the g-w. I linked this discussion into the relevant issue NOAA-EMC/global-workflow#812. I believe this conversation can be resolved.