Replace hardcoded tx costs with a call to eth_estimateGas #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Dec 8, 2023
transactions.go
Outdated
| conf.gasLimit = gas | ||
|
|
||
| // this works because noAlStrategies ⊂ alStrategies | ||
| return alStrategies[index](conf) |
There was a problem hiding this comment.
I didn't want to pass the client around so what I did was to get a first transaction generated, have it estimated, and then generate a new one with the same gas. I don't really like this, because these are two different transactions and that could fail.
gballet
changed the title
MariusVanDerWijden
merged commit 264171c
into
MariusVanDerWijden:master
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using tx-fuzz on the verkle testnet, we found some issues caused by the change in the gas schedule. Transactions now have to pay for the witness costs, so call
estimateGasin order to find out what the price of a transaction is going to be, before sending it.Creating this PR as a draft as there is still an open question (see comment).