Replace hardcoded tx costs with a call to eth_estimateGas (#46)

* use estimate gas when sending legacy txs * fix estimation gas limit + log estimate failure * txfuzz: move gas estimation * spammer: uppercase --------- Co-authored-by: Marius van der Wijden <[email protected]>
MariusVanDerWijden · Jan 15, 2024 · 264171c · 264171c
1 parent d8b943f
commit 264171c
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 12 deletions.
diff --git a/spammer/addresslist.go b/spammer/addresslist.go
@@ -6,11 +6,14 @@ import (
 	"math/big"
 	"time"
 
+	"github.com/ethereum/go-ethereum"
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
 	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/common/math"
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/crypto"
 	"github.com/ethereum/go-ethereum/ethclient"
+	"github.com/ethereum/go-ethereum/log"
 )
 
 var (
@@ -145,6 +148,7 @@ func CreateAddresses(N int) ([]string, []string) {
 func Airdrop(config *Config, value *big.Int) error {
 	backend := ethclient.NewClient(config.backend)
 	sender := crypto.PubkeyToAddress(config.faucet.PublicKey)
+	fmt.Printf("Airdrop faucet is at %x\n", sender)
 	var tx *types.Transaction
 	chainid, err := backend.ChainID(context.Background())
 	if err != nil {
@@ -159,7 +163,19 @@ func Airdrop(config *Config, value *big.Int) error {
 		}
 		to := crypto.PubkeyToAddress(addr.PublicKey)
 		gp, _ := backend.SuggestGasPrice(context.Background())
-		tx2 := types.NewTransaction(nonce, to, value, 21000, gp, nil)
+		gas, err := backend.EstimateGas(context.Background(), ethereum.CallMsg{
+			From:     crypto.PubkeyToAddress(config.faucet.PublicKey),
+			To:       &to,
+			Gas:      math.MaxInt64,
+			GasPrice: gp,
+			Value:    value,
+			Data:     nil,
+		})
+		if err != nil {
+			log.Error("error estimating gas: %v", err)
+			return err
+		}
+		tx2 := types.NewTransaction(nonce, to, value, gas, gp, nil)
 		signedTx, _ := types.SignTx(tx2, types.LatestSignerForChainID(chainid), config.faucet)
 		if err := backend.SendTransaction(context.Background(), signedTx); err != nil {
 			fmt.Printf("error sending transaction; could not airdrop: %v\n", err)

diff --git a/spammer/helper.go b/spammer/helper.go
@@ -8,8 +8,10 @@ import (
 	"math/big"
 	"time"
 
+	"github.com/ethereum/go-ethereum"
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
 	"github.com/ethereum/go-ethereum/common"
+	"github.com/ethereum/go-ethereum/common/math"
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/crypto"
 	"github.com/ethereum/go-ethereum/ethclient"
@@ -32,7 +34,15 @@ func sendTxWithNonce(sk *ecdsa.PrivateKey, backend *ethclient.Client, to common.
 		return nil, err
 	}
 	gp, _ := backend.SuggestGasPrice(context.Background())
-	tx := types.NewTransaction(nonce, to, value, 500000, gp.Mul(gp, big.NewInt(100)), nil)
+	gas, _ := backend.EstimateGas(context.Background(), ethereum.CallMsg{
+		From:     crypto.PubkeyToAddress(sk.PublicKey),
+		To:       &to,
+		Gas:      math.MaxUint64,
+		GasPrice: gp,
+		Value:    value,
+		Data:     nil,
+	})
+	tx := types.NewTransaction(nonce, to, value, gas, gp.Mul(gp, big.NewInt(100)), nil)
 	signedTx, _ := types.SignTx(tx, types.NewEIP155Signer(chainid), sk)
 	return signedTx, backend.SendTransaction(context.Background(), signedTx)
 }

diff --git a/transactions.go b/transactions.go
@@ -3,11 +3,13 @@ package txfuzz
 import (
 	"context"
 	"crypto/sha256"
+	"math"
 	"math/big"
 	"math/rand"
 
 	"github.com/MariusVanDerWijden/FuzzyVM/filler"
 	"github.com/MariusVanDerWijden/FuzzyVM/generator"
+	"github.com/ethereum/go-ethereum"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/crypto/kzg4844"
@@ -44,6 +46,14 @@ type txConf struct {
 }
 
 func initDefaultTxConf(rpc *rpc.Client, f *filler.Filler, sender common.Address, nonce uint64, gasPrice, chainID *big.Int) *txConf {
+	// defaults
+	gasCost := uint64(100000)
+	to := randomAddress()
+	code := RandomCode(f)
+	value := big.NewInt(0)
+	if len(code) > 128 {
+		code = code[:128]
+	}
 	// Set fields if non-nil
 	if rpc != nil {
 		client := ethclient.NewClient(rpc)
@@ -60,21 +70,29 @@ func initDefaultTxConf(rpc *rpc.Client, f *filler.Filler, sender common.Address,
 				chainID = big.NewInt(1)
 			}
 		}
+		// Try to estimate gas
+		gas, err := client.EstimateGas(context.Background(), ethereum.CallMsg{
+			From:      sender,
+			To:        &to,
+			Gas:       math.MaxUint64,
+			GasPrice:  gasPrice,
+			GasFeeCap: gasPrice,
+			GasTipCap: gasPrice,
+			Value:     value,
+			Data:      code,
+		})
+		if err == nil {
+			gasCost = gas
+		}
 	}
-	gas := uint64(100000)
-	to := randomAddress()
-	code := RandomCode(f)
-	value := big.NewInt(0)
-	if len(code) > 128 {
-		code = code[:128]
-	}
+
 	return &txConf{
 		rpc:      rpc,
 		nonce:    nonce,
 		sender:   sender,
 		to:       &to,
 		value:    value,
-		gasLimit: gas,
+		gasLimit: gasCost,
 		gasPrice: gasPrice,
 		chainID:  chainID,
 		code:     code,
@@ -87,11 +105,12 @@ func initDefaultTxConf(rpc *rpc.Client, f *filler.Filler, sender common.Address,
 // If chainID is not set, we will try to get it from the rpc
 func RandomValidTx(rpc *rpc.Client, f *filler.Filler, sender common.Address, nonce uint64, gasPrice, chainID *big.Int, al bool) (*types.Transaction, error) {
 	conf := initDefaultTxConf(rpc, f, sender, nonce, gasPrice, chainID)
+	var index int
 	if al {
-		index := rand.Intn(len(alStrategies))
+		index = rand.Intn(len(alStrategies))
 		return alStrategies[index](conf)
 	} else {
-		index := rand.Intn(len(noAlStrategies))
+		index = rand.Intn(len(noAlStrategies))
 		return noAlStrategies[index](conf)
 	}
 }