-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New guesser interface broke behaviour downstream #4748
Comments
I'm just out but can look at this in an hour or so! |
Prolif also fails because we removed the guessers interface: ModuleNotFoundError: No module named 'MDAnalysis.topology.guessers' |
Similarly pytim fails because it attempts to call |
cc @Marcello-Sega - this is where we're tracking the breaking changes from the guessers update: MDAnalysis/MDAKits#217 |
@lilyminium and @IAlibay I put both your names on this omnibus issue as the two people with best insight into what needs to be done. You also already created PRs addressing all the sub-issues (thank you!) so I assigned the issues to the PR authors so that it's clear that we are actively working on the problems. Please ask for help where needed. |
I created the post #4758 as an official note. |
Several mdakits' CI broke overnight with the following error: ValueError: there is no reference attributes in this universeto guess types froma
This means that the new guessers interface did a breaking change that we aren't aware of.
This will need to be fixed before the 2.8 release.
The text was updated successfully, but these errors were encountered: