-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change error to warning on Universe creation #4754
Change error to warning on Universe creation #4754
Conversation
Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-10-25 04:49:48 UTC |
@lilyminium can you point out to which specific sub-issue you're fixing under #4748? |
I've edited my comment, thanks |
Can you please add in the test from #4750 if it's fixing it too? |
There's already a test for numpy arrays but sure |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4754 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 175 187 +12
Lines 21564 22640 +1076
Branches 3023 3024 +1
===========================================
+ Hits 20195 21198 +1003
- Misses 925 998 +73
Partials 444 444 ☔ View full report in Codecov by Sentry. |
@lilyminium I am assigning the PR to you. You'll know best when to merge. |
Thanks for the review @orbeckst! I've made some markup changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm — but other reviews welcome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Fixes #4750
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin