Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split convert.jl into smaller files #3618

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Split convert.jl into smaller files #3618

merged 1 commit into from
Sep 9, 2024

Conversation

schillic
Copy link
Member

No description provided.

@schillic schillic marked this pull request as ready for review July 26, 2024 08:38
mforets
mforets approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mforets mforets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this and recall we discussed it already, so approving.

(But my personal choice would be not to fragment that much. We now end up with lots and lost of files that extend the same Julia method, with 50 loc or less, which seems kind of awkward.)

@mforets
Copy link
Member

mforets commented Sep 9, 2024

The approach taken in which the file name corresponds to the target set is nice though.

@schillic schillic merged commit 24e8b1b into master Sep 9, 2024
5 of 6 checks passed
@schillic schillic deleted the schillic/convert branch September 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets