-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add demo: inpainting #138
Open
mgautam98
wants to merge
1
commit into
JuliaImages:source
Choose a base branch
from
MLH-Fellowship:inpainting
base: source
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add demo: inpainting #138
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# --- | ||
# title: Image Inpainting | ||
# cover: assets/inpainting.png | ||
# --- | ||
|
||
# This demo illustrates the use of [image inpainting](https://github.com/JuliaImages/ImageInpainting.jl) algorithm in JuliaImages. | ||
|
||
# Inpainting is the process of constructing lost or deteriorated parts of an | ||
# image or video. It is also used for removing undesired elements from a scene. | ||
# | ||
# The basic idea of inpainting is: Replace those bad marks (or undesired elements) with its | ||
# neighbouring pixels so that it looks like the neighbourhood. | ||
|
||
# In this demo we will be removing an undesired element form an image. | ||
|
||
using ImageInpainting, TestImages, ImageCore | ||
|
||
img = Float64.(Gray.(testimage("lighthouse"))); | ||
Gray.(img) | ||
|
||
# Create a mask of same size as of image | ||
mask = falses(size(img)); | ||
|
||
# pixels where mask is set to true will be inpainted | ||
mask[50:350,300:400] .= true; | ||
Gray.(mask) | ||
|
||
# inpaint take the parametes image, mask and algorithm. | ||
# We will be using Criminisi [1] algorithm | ||
out = inpaint(img, mask, Criminisi(30,30)); | ||
|
||
mosaicview(Gray.(img), Gray.(mask), Gray.(out); nrow = 1) | ||
|
||
# Note: Currently, ImageInpainting.jl only supports 2D images | ||
# ### References | ||
# [1] Criminisi, A., Pérez, P., Toyama, K., 2004. Region Filling | ||
# and Object Removal by Examplar-based Image Inpainting. | ||
|
||
# --- save covers --- #src | ||
using FileIO #src | ||
save("assets/inpainting.png", mosaicview(Gray.(img), Gray.(out); nrow = 1)) #src | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it because the
inpaint
only accepts numerical array as inputs? In that case, we should fix and make it also works forAbstractArray{<:AbstractGray}
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I would like to work on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the algorithm isn't optimized well, the memory allocation is conspicuous to me.
I'm not sure what's currently on your TODO list, but I guess this is also worth checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update on this:
😄 It's pretty slow,let's check