add demo: inpainting #138
Open
add demo: inpainting #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| using ImageInpainting, TestImages, ImageCore | ||
|
|
||
| img = Float64.(Gray.(testimage("lighthouse"))); |
There was a problem hiding this comment.
Is it because the inpaint only accepts numerical array as inputs? In that case, we should fix and make it also works for AbstractArray{<:AbstractGray}.
There was a problem hiding this comment.
Okay I would like to work on that
There was a problem hiding this comment.
It looks like the algorithm isn't optimized well, the memory allocation is conspicuous to me.
julia> @time out = inpaint(img, mask, Criminisi(30,30));
14.502141 seconds (2.16 M allocations: 13.540 GiB, 18.97% gc time)I'm not sure what's currently on your TODO list, but I guess this is also worth checking.
There was a problem hiding this comment.
Update on this:
@time out = inpaint(img, mask, Criminisi(30,30));
17.644576 seconds (4.94 M allocations: 13.659 GiB, 3.46% gc time)😄 It's pretty slow,let's check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a demo of Image inpainting
@johnnychen94