Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataloader): refine implementation of mocked and megatron dataloader #344

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

zigzagcai
Copy link
Collaborator

@zigzagcai zigzagcai commented Sep 24, 2024

Motivation

  1. Fix CI timeout for [Bug] There will be timeout in some cases. #342 (Completed)
  2. Refine implementation of megatron and mocked dataloader (Completed)

Modification

  • internlm/train/pipeline.py
  • internlm/data/*

BC-breaking (Optional)

None

Use cases (Optional)

None

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zigzagcai zigzagcai changed the title fix(CI): fix CI timeout for some cases fix(CI): fix CI timeout for some cases and add some code refinement Sep 26, 2024
@zigzagcai zigzagcai changed the title fix(CI): fix CI timeout for some cases and add some code refinement feat(dataloader): refine implementation of mocked and megatron dataloader Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants