Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses Ruff as code formater and linter #59

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Uses Ruff as code formater and linter #59

merged 5 commits into from
Jan 16, 2024

Conversation

dalonsoa
Copy link
Contributor

@dalonsoa dalonsoa commented Jan 8, 2024

Description

Replaces flake8, black and other tools with Ruff, which seems to work well, it is easy to configure and we have been using it already in several projects without any problem.

Fixes #56

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

N/A

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Copy link

@TinyMarsh TinyMarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already started using it also, so I approve!

Copy link
Contributor

@dc2917 dc2917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think it's about time I started using ruff myself

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Daniel Cummins <[email protected]>
@dalonsoa dalonsoa merged commit 6a137a5 into main Jan 16, 2024
10 checks passed
@dalonsoa dalonsoa deleted the ruff branch January 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from flake8 and friends to ruff
4 participants