Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff as linter and code formatter #106

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Use ruff as linter and code formatter #106

merged 1 commit into from
Jan 11, 2024

Conversation

dalonsoa
Copy link
Contributor

@dalonsoa dalonsoa commented Jan 9, 2024

Description

Like in ImperialCollegeLondon/poetry_template_2#59, this PR replaces flake8, black and other tools with Ruff, which seems to work well, it is easy to configure and we have been using it already in several projects without any problem.

Fixes # (NONE)

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

N/A

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@dalonsoa dalonsoa merged commit 5f9d960 into main Jan 11, 2024
11 checks passed
@dalonsoa dalonsoa deleted the ruff branch January 11, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants