Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Let's get you set up 🔧 " line during onboarding #52728

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+1 −19
Open

Remove "Let's get you set up 🔧 " line during onboarding #52728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b27f20d
Update CONST.ts
jamesdeanexpensify Nov 18, 2024
c701612
Update Report.ts
jamesdeanexpensify Nov 18, 2024
a5a35af
Update Report.ts
jamesdeanexpensify Nov 19, 2024
b7f331e
Update Report.ts
jamesdeanexpensify Nov 19, 2024
f8c3d95
Update Report.ts
jamesdeanexpensify Nov 19, 2024
0dc28f1
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
601b4e0
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
ce49dc3
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
c5afbcf
Update src/libs/actions/Report.ts
jamesdeanexpensify Nov 19, 2024
23c6802
Run prettier
marcaaron Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4821,7 +4821,6 @@ const CONST = {

WELCOME_VIDEO_URL: `${CLOUDFRONT_URL}/videos/intro-1280.mp4`,

ONBOARDING_INTRODUCTION: 'Let’s get you set up 🔧',
ONBOARDING_CHOICES: {...onboardingChoices},
SELECTABLE_ONBOARDING_CHOICES: {...selectableOnboardingChoices},
COMBINED_TRACK_SUBMIT_ONBOARDING_CHOICES: {...combinedTrackSubmitOnboardingChoices},
Expand Down
19 changes: 1 addition & 18 deletions src/libs/actions/Report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3498,15 +3498,6 @@ function prepareOnboardingOptimisticData(
const targetChatReport = ReportUtils.getChatByParticipants([actorAccountID, currentUserAccountID]);
const {reportID: targetChatReportID = '', policyID: targetChatPolicyID = ''} = targetChatReport ?? {};

// Introductory message
const introductionComment = ReportUtils.buildOptimisticAddCommentReportAction(CONST.ONBOARDING_INTRODUCTION, undefined, actorAccountID);
const introductionCommentAction: OptimisticAddCommentReportAction = introductionComment.reportAction;
const introductionMessage: AddCommentOrAttachementParams = {
reportID: targetChatReportID,
reportActionID: introductionCommentAction.reportActionID,
reportComment: introductionComment.commentText,
};

// Text message
const textComment = ReportUtils.buildOptimisticAddCommentReportAction(data.message, undefined, actorAccountID, 1);
const textCommentAction: OptimisticAddCommentReportAction = textComment.reportAction;
Expand Down Expand Up @@ -3753,7 +3744,6 @@ function prepareOnboardingOptimisticData(
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${targetChatReportID}`,
value: {
[introductionCommentAction.reportActionID]: introductionCommentAction as ReportAction,
[textCommentAction.reportActionID]: textCommentAction as ReportAction,
},
},
Expand All @@ -3776,7 +3766,6 @@ function prepareOnboardingOptimisticData(
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${targetChatReportID}`,
value: {
[introductionCommentAction.reportActionID]: {pendingAction: null},
[textCommentAction.reportActionID]: {pendingAction: null},
},
});
Expand Down Expand Up @@ -3811,9 +3800,6 @@ function prepareOnboardingOptimisticData(
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${targetChatReportID}`,
value: {
[introductionCommentAction.reportActionID]: {
errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('report.genericAddCommentFailureMessage'),
} as ReportAction,
[textCommentAction.reportActionID]: {
errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('report.genericAddCommentFailureMessage'),
} as ReportAction,
Expand Down Expand Up @@ -3866,10 +3852,7 @@ function prepareOnboardingOptimisticData(
});
}

const guidedSetupData: GuidedSetupData = [
{type: 'message', ...introductionMessage},
{type: 'message', ...textMessage},
];
const guidedSetupData: GuidedSetupData = [{type: 'message', ...textMessage}];

if ('video' in data && data.video && videoCommentAction && videoMessage) {
optimisticData.push({
Expand Down
Loading