-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Let's get you set up 🔧 " line during onboarding #52728
Open
jamesdeanexpensify
wants to merge
10
commits into
main
Choose a base branch
from
jamesdeanexpensify-patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
marcaaron
and removed request for
a team
November 18, 2024 22:15
@marcaaron i probably messed some part of this up, but the linked Slack convo will show you exactly what we're trying to do, thank you! |
marcaaron
previously requested changes
Nov 19, 2024
Do the QA steps look OK, as well? |
marcaaron
reviewed
Nov 19, 2024
marcaaron
reviewed
Nov 19, 2024
marcaaron
reviewed
Nov 19, 2024
Co-authored-by: Marc Glasser <[email protected]>
Co-authored-by: Marc Glasser <[email protected]>
Co-authored-by: Marc Glasser <[email protected]>
Co-authored-by: Marc Glasser <[email protected]>
marcaaron
reviewed
Nov 19, 2024
marcaaron
dismissed
their stale review
November 19, 2024 01:26
I added commits so removing myself as a reviewer.
Looks like everything is passing here. Tested locally and looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this Slack thread for more details (and what I'm trying to do!):
https://expensify.slack.com/archives/C07HPDRELLD/p1731966744741239
Explanation of Change
Fixed Issues
$ https://expensify.slack.com/archives/C07HPDRELLD/p1731966744741239
PROPOSAL:
Tests
Offline tests
QA Steps
Repeat the process above, but for the remaining four (4) onboarding options:
Manage my team's expenses
Get paid back by my employer
Chat and split expenses with friends
Something else
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop