WIP 645-human-readable-uefi-secure-boot-key-enrollment-menu

[philipandag]

No description provided.

[philipandag]

Most commits were not accepted as verified. I will try to fix it now/

[miczyg1]

If AllocateZeroPool(100) return EFI_OUT_OF_RESOURCES then everything should simply fall apart. There are plenty of places where AllocateZeroPool is used, so there must be something wrong going on here.

[philipandag]

Maybe, that was an hypothesis i had because the certificate entries were not wrong, the list was not rendered at all, even the help on the right side. I copied the usage of AllocateZeroPool from this function, including the GOTO statement and figured that GOTO must be causing the rendering to be skipped. I should have stated that it is just a hypothesis, I did not confirm that was the cause of the error.

Either way it works fine now. Should I rewrite this using AsciiStrnToUnicodeStrS and a second buffer instead?

[mkopec]

@philipandag Yes, let's try that

[philipandag]

We have decided to use the X509GetCommonName function instead of X509GetSubjectName. The first one returns an ascii string which can be directly converted to unicode and displayed. The latter returns an array of bytes (UINT8) which needs to be further converted to useful text which is troublesome when using the AsciiStrToUnicodeStrS function. The feature now works on delete pages od KEK and DB keys.

[mkopec]

@philipandag can you squash some of these commits? This will make dealing with this after merging (e.g. rebasing, resolving conflics) much easier down the line

[philipandag]

Squashed where it made sense. It seems that squashing broke the verification so another rebase is coming...

[krystian-hebel]

Is Pk even needed here? I think (VOID **)&PkList should work just as good.

[krystian-hebel]

Is there a reason why this is set to 100?

X509GetCommonName() can return the required size by passing NULL as CommonName, that size could be then used to allocate the buffers and X509GetCommonName() can then be repeated with CommonName set to allocated buffer.

Alternatively, this length can be set to whatever fits in GUI (e.g. if multi-line name could impact test automation), but then we would have to somehow mark when the rest was truncated, e.g. by appending ... at the end, but then it may skip the important parts after generic company name.