SecureBootConfigImpl.c: Try creating popup

Signed-off-by: Filip Go¿a¿ <[email protected]> ..Impl.c: Process PK_INFO in ACTION_FORM_OPEN action Signed-off-by: Filip Go¿a¿ <[email protected]> SecureBootConfig.vfr: add flags are they required? Signed-off-by: Filip Go¿a¿ <[email protected]> SecureBootConfigImpl.c: Try checking key in two places Signed-off-by: Filip Go¿a¿ <[email protected]>
Dasharo · Aug 9, 2024 · 19439bd · 19439bd
1 parent 6bda65a
commit 19439bd
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 7 deletions.
diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfig.vfr b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfig.vfr
@@ -152,7 +152,7 @@ formset
     text
          help   = STRING_TOKEN(STR_PK_INFO_HELP),
          text   = STRING_TOKEN(STR_PK_INFO),
-         flags  = INTERACTIVE,
+         flags  = READ_ONLY,
          key    = KEY_PK_INFO;
     endif;
 

diff --git a/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c b/SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c
@@ -4696,6 +4696,17 @@ SecureBootCallback (
         //
         IfrNvData->ListCount = Private->ListCount;
       }
+      if ((QuestionId == KEY_PK_INFO))
+      {
+        CreatePopUp (
+            EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
+            &Key,
+            L"PK INFO form open",
+            L"PK INFO 2",
+            NULL
+            );
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_PK_INFO), L"PK INFO form open", NULL);
+      }
     }
 
     goto EXIT;
@@ -4747,7 +4758,17 @@ SecureBootCallback (
         }
 
         break;
-
+      case KEY_PK_INFO:
+      {
+        CreatePopUp (
+          EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE,
+          &Key,
+          L"PK INFO form changing",
+          L"PK INFO 2",
+          NULL
+        );
+        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_PK_INFO), L"PK INFO changing", NULL);
+      }
       case KEY_SECURE_BOOT_KEK_OPTION:
       case KEY_SECURE_BOOT_DB_OPTION:
       case KEY_SECURE_BOOT_DBX_OPTION:
@@ -5215,11 +5236,6 @@ SecureBootCallback (
         }
 
         break;
-      case KEY_PK_INFO:
-      {
-        HiiSetString (PrivateData->HiiHandle, STRING_TOKEN (STR_PK_INFO), L"TEST CHANGING STRING", NULL);
-        break;
-      }
 
       case KEY_SECURE_BOOT_RESET_TO_DEFAULT:
       {