Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct percentages for STV and first-round-determines-threshold #883

Merged
merged 4 commits into from
Sep 25, 2024
Merged

correct percentages for STV and first-round-determines-threshold #883

merged 4 commits into from
Sep 25, 2024

Conversation

artoonie
Copy link
Collaborator

@artoonie artoonie commented Sep 4, 2024

closes #851

@artoonie artoonie force-pushed the feature/issue-851_correct-denominator branch from 1ce0981 to be9d80c Compare September 4, 2024 16:32
@yezr yezr linked an issue Sep 9, 2024 that may be closed by this pull request
Use correct "% of Vote" column denominator in summary.csv #851
Open
@yezr
Copy link
Collaborator

yezr commented Sep 9, 2024

Testing

  • confirmed examples in Use correct "% of Vote" column denominator in summary.csv #851 are now correct. these cover both stv and irv w/ first round determines threshold
  • confirmed changes in other summary.csv files are all from races we'd expect to change (either STV or IRV w/ first round determines threshold) and all w/ vote % going down (since we are no longer removing inactives from the divisor during rounds)

LGTM!

@artoonie
STV last round use "Final Round Surplus" rather than inactive (#884)
599f098 
* STV last round use "Final Round Surplus" rather than inactive

* PR Review: clean up, simpler configs

* fix incorrect transfers

* clean up with ternary operator

* bring text variations within the enum

* PR Review Comments: clean up STATUSES_TO_PRINT
@artoonie artoonie merged commit 124737a into feature/issue-871_tabulate-by-csv-updates Sep 25, 2024
1 check passed
@artoonie artoonie deleted the feature/issue-851_correct-denominator branch September 25, 2024 18:22
@yezr yezr mentioned this pull request Sep 25, 2024
Merged
artoonie added a commit that referenced this pull request Sep 25, 2024
@artoonie @RankWeis @yezr
Updates to the per-slice CSV (#872)
639ee63 
* Updates to the per-slice CSV

* Update src/main/java/network/brightspots/rcv/ResultsWriter.java

Co-authored-by: RankWeis <[email protected]>

* fix typo

Co-authored-by: Mathew Ruberg <[email protected]>

* remove unneeded commit

* Code review: add batch test, clean up results writer, error handling

* PR Review

* correct percentages for STV and first-round-determines-threshold (#883)

* correct percentages for STV and first-round-determines-threshold

* vote % divisor fix

* fix tests

* STV last round use "Final Round Surplus" rather than inactive (#884)

* STV last round use "Final Round Surplus" rather than inactive

* PR Review: clean up, simpler configs

* fix incorrect transfers

* clean up with ternary operator

* bring text variations within the enum

* PR Review Comments: clean up STATUSES_TO_PRINT

---------

Co-authored-by: yezr <[email protected]>

---------

Co-authored-by: RankWeis <[email protected]>
Co-authored-by: Mathew Ruberg <[email protected]>
Co-authored-by: yezr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezr yezr yezr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use correct "% of Vote" column denominator in summary.csv
2 participants
@artoonie @yezr