Overmap Ship normal damage type immunity

[SerynEngi]

About The Pull Request

This PR adds armor to overmap ships of all types for all non-shipboard overmap armor types.

Why It's Good For The Game

Reduces/prevents the rare overmap bug exploitation from killing ships.

Changelog

🆑
fix: Added normal armor to all overmap ships.
/:cl:

[Bokkiewokkie]

They shouldn't have 100 bomb protection because explosions on the overmap are funny (they can still have a lot, however).
Fire damage is also applied by incendiary weapons and shouldn't have any.

[DeltaFire15]

This is so much copypasta, maybe make a OVERMAP_BASE_ARMOR_VALUES define and put the copypasted part of the armor list in there? Since defines are replaced at compile time it should be fine to use in that list.

[Bokkiewokkie]

This is so much copypasta, maybe make a OVERMAP_BASE_ARMOR_VALUES define and put the copypasted part of the armor list in there? Since defines are replaced at compile time it should be fine to use in that list.

Agree with this, it also makes it easier to adjust globally (since I see you still missed a couple of fire armour values)

[Karmic-Skink]

There is a proc to add armour values that be added to late initialize etc

[Bokkiewokkie]

There is a proc to add armour values that be added to late initialize etc

@SerynEngi can you actually do this instead, you only have to add it to the /obj/structure/overmap type once
Also it seems you've removed the armour list of the mining ship completely by accident.

[Bokkiewokkie]

see comment above

[Bokkiewokkie]

Yes excellent commit 👍

Outdated