Fix bug where scalar phase was not conjugated by BaseGraph.adjoint() #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid the fix will be a bit more complicated than that. A Scalar has a |
|
Thanks! This is great :) |
dlyongemallo
reviewed
Jun 7, 2024
| @@ -176,6 +188,7 @@ def setUp(self): | |||
| g.set_outputs((o1, o2)) | |||
| g.add_edges([(i1,v),(i2,w),(v,w),(v,o1),(w,o2)]) | |||
| self.i1, self.i2, self.v, self.w, self.o1, self.o2 = i1, i2, v, w, o1, o2 | |||
| print(self.graph.scalar.to_number()) | |||
There was a problem hiding this comment.
Was this a debugging statement which was left in accidentally?
It causes the output of the test to look like this:
..................s............(1+0j)
.(1+0j)
.(1+0j)
.(1+0j)
.........................sssss.............................
----------------------------------------------------------------------
Ran 93 tests in 3.109s
OK (skipped=6)
There was a problem hiding this comment.
Sorry, yes I left it accidentally. I saw that you already removed it, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #229