Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add Namron 4512748 2A Awning Controller #7088

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 172 additions & 0 deletions packages/config/config/devices/0x0438/4512748.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
{
"manufacturer": "Namron",
"manufacturerId": "0x0438",
"label": "4512748",
"description": "Awning Controller",
"devices": [
{
"productType": "0x0004",
"productId": "0x53261"
}
],
"firmwareVersion": {
"min": "0.0",
"max": "255.255"
},
"associations": {
"1": {
"label": "Lifeline",
"maxNodes": 5,
"isLifeline": true
}
},
"paramInformation": [
{
"#": "2",
"label": "Enable/Disable State Report Threshold",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using "Enable/Disable" in labels. Usually there is a better label, or the options already imply that they are meant for enabling or disabling something.

"valueSize": 1,
"description": "0: Disable to report actively 1- 10: value to report, unit is one percent",
"defaultValue": 5
},
{
"#": "3",
"label": "Working Mode",
"valueSize": 1,
"defaultValue": 2,
"allowManualEntry": false,
"options": [
{
"value": 0,
"label": "Light Mode"
},
{
"value": 1,
"label": "Shutter mode without positioning"
},
{
"value": 2,
"label": "Shutter mode without positioning"
}
]
},
{
"#": "4",
"$import": "~/templates/master_template.json#base_enable_disable",
"label": "Enable/Disable Save Positioning Percentage",
"valueSize": 1,
"defaultValue": 1
},
{
"#": "5",
"$import": "~/templates/master_template.json#base_enable_disable",
"label": "Enable/Disable Overcurrent Protection",
"valueSize": 1,
"defaultValue": 1
},
{
"#": "6",
"label": "Starting Positioning Calibration Performed",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like it indicates a status, but is writeonly?

"valueSize": 1,
"writeOnly": true,
"defaultValue": 0
},
{
"#": "7",
"label": "Configuration Of Button S1 And S2 Control",
"valueSize": 1,
"defaultValue": 0,
"unsigned": true,
"allowManualEntry": false,
"options": [
{
"label": "Value=0",
"value": 0
},
{
"label": "Value=1",
"value": 1
},
{
"label": "Value=2",
"value": 2
},
{
"label": "Value=3",
"value": 3
},
{
"label": "Value=4",
"value": 4
}
Comment on lines +81 to +100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do those values mean? "Value=3" isn't self-explanatory.

]
},
{
"#": "8",
"$import": "~/templates/master_template.json#base_enable_disable",
"label": "Enable/Disable Inclusion/Exclusion Through S1 Button",
"valueSize": 1,
"defaultValue": 1
},
{
"#": "9",
"label": "Enable/Disable Scene Activation Through S1 and S2 Switches",
"valueSize": 1,
"defaultValue": 1,
"allowManualEntry": false,
"options": [
{
"label": "Disable to send for action of both S1 and S2",
"value": 0
},
{
"label": "Enable to send for action of both S1 and S2",
"value": 1
},
{
"label": "Enable to send for action of only S1",
"value": 2
},
{
"label": "Enable to send for action of only S2",
"value": 3
}
]
},
{
"#": "10",
"label": "Power Change Threshold Limit",
"valueSize": 1,
"defaultValue": 10
Comment on lines +137 to +139
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the following parameters are missing:

  • unit (can also be sth. like "0.1 V")
  • mininum and maximum value

},
{
"#": "11",
"label": "Current Change Threshold Limit",
"valueSize": 1,
"defaultValue": 1
},
{
"#": "12",
"label": "Voltage Change Threshold Limit",
"valueSize": 1,
"defaultValue": 2
},
{
"#": "13",
"label": "Slats Rotation Time",
"valueSize": 1,
"defaultValue": 0
},
{
"#": "14",
"label": "Time Cycle To Report Energy Consumption Value",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically reword the labels to something more understandable, in this case:

Suggested change
"label": "Time Cycle To Report Energy Consumption Value",
"label": "Energy Report Interval",

"valueSize": 4,
"defaultValue": 3600
}
],
"metadata": {
"inclusion": "Select menu item “Net”, then find IN and long-press M for 2s.",
"exclusion": "Select menu item “Net”, then find OUT and long-press M for 2s.",
"reset": "Select menu item “Net”, then find OUT and long-press M for 2s.",
"manual": "https://www.elektroimportoren.no/docs/lib/4512748-Brukerveiledning-5.pdf"
}
}
Loading