feat(config): allow manual entry for LED intensity parameters for Inovelli LZW30 #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…velli LZW30 Black Series On/Off Switch with the documentation and expected behavior. By allowing manual entry for values between 0 and 10, this update ensures consistency with other Inovelli products and provides a more intuitive user experience. The new configuration allows users to set the LED intensity directly, improving the alignment with Inovelli's specifications and enhancing control.
anderbak
changed the title
|
I'm not sure I understand the change. You can already enter values between 0 and 10 because of the predefined options. |
|
Hello, The predefined options are a selection of text values that correspond to the number values between 0 and 10. It is not consistent with other inovelli device configurations nor does it align with the documentation from inovelli. LZW30 parameters pg 42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the LED intensity parameters for the Inovelli LZW30 switch.
The changes allow manual entry of values between 0 and 10 for parameters 6 and 7,
providing more granular control over LED brightness. This change aligns with
Inovelli's documentation and improves consistency across devices.