Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport OTEL autoinstrumentation from series/2.x #654

Draft
wants to merge 1 commit into
base: series/1.x
Choose a base branch
from
Draft

Backport OTEL autoinstrumentation from series/2.x #654

wants to merge 1 commit into from

Conversation

grouzen
Copy link
Contributor

@grouzen grouzen commented Feb 16, 2023

No description provided.

@grouzen grouzen linked an issue Feb 16, 2023 that may be closed by this pull request
Backport OpenTelemetry autoinstrumentation into series/1.x #612
Open
@grouzen grouzen mentioned this pull request Feb 28, 2023
Merged
@dmytr
Copy link
Contributor

dmytr commented Apr 14, 2023 •
edited
Loading

Hi @grouzen,

As of today, PropagatingSupervisor is not needed any more, because ZIO 2.0 instrumentation has landed in OpenTelemetry Java Agent v1.25.0 (release notes). We should remove it from series 2 and 3 as well. I could look into this when I have some spare time.

@grouzen
Copy link
Contributor Author

grouzen commented Apr 18, 2023 •
edited
Loading

Hi @dmytr!

It is nice to hear. Thanks for your contribution!

I'm also still working on adding an example of how to use auto instrumentation, but I'm failing to make it work with Jaeger. Can I ask you to help me with this when you have time?

@dmytr
Copy link
Contributor

dmytr commented May 6, 2023

Hi @grouzen,

I've done a bit of clean up to remove now obsolete PropagatingSupervisor in #681.

Seems like it would be relevant for this PR.

@grouzen
Copy link
Contributor Author

grouzen commented May 6, 2023

Thanks! Yeah, I'll update this PR after we merge yours.

@grouzen
Copy link
Contributor Author

grouzen commented May 23, 2023

It seems we still need to keep PropagatingSupervisor you implemented for series/1.x since java-insturmentation supports zio2 only.

@dmytr
Copy link
Contributor

dmytr commented May 23, 2023

Oh right... 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport OpenTelemetry autoinstrumentation into series/1.x
2 participants
@grouzen @dmytr