Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laduke/190 windows #191

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Laduke/190 windows #191

merged 3 commits into from
Sep 4, 2024

Conversation

laduke
Copy link
Contributor

@laduke laduke commented Sep 4, 2024

No description provided.

rcoder
rcoder reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@rcoder rcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a worthwhile addition. One small suggestion to direct people towards a more specific kind of feedback/follow-up.

docs/windows-service-unreachable.md Outdated Show resolved Hide resolved
rcoder
rcoder approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@rcoder rcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@laduke laduke merged commit 47786bc into main Sep 4, 2024
1 check passed
@laduke laduke deleted the laduke/190-windows branch September 4, 2024 22:37
@laduke laduke mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcoder rcoder rcoder approved these changes

@danitheturtle danitheturtle Awaiting requested review from danitheturtle danitheturtle is a code owner

@glimberg glimberg Awaiting requested review from glimberg glimberg is a code owner

@joseph-henry joseph-henry Awaiting requested review from joseph-henry joseph-henry is a code owner

@aaronjohnson aaronjohnson Awaiting requested review from aaronjohnson aaronjohnson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laduke @rcoder