feat(compiler): complexity per node #788
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prints
This PR is not complete ATM!
Complexity of wopPBS is not calculated.
It turns out this is not as straightforward...
Fusing can lead to unexpected output.
results in
As %3 and %5 is fused in the internal table lookups of %6.
There are some inconsistencies between the compiler and the optimizer.
It's even present in the example code in this PR. It'd be best if we can resolve it and have tests with different combinations of operations.
Btw, this issue is not just originating from this PR. Subtraction for example is implemented as
x + (-y)
in the compiler, but the optimizer considers it a single linear operation and gives incorrect complexity, which is half of what it should have been.