Set correct cluster tag on EKS #8487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
added
the
minor
|
👍 |
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
eks-fix-cluster-tag
branch
3 times, most recently
from
a6ebc87
to
d572f40
Compare
mikkeloscar
force-pushed
the
eks-fix-cluster-tag
branch
from
d572f40
to
2b62cd2
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
eks-fix-cluster-tag
branch
from
2b62cd2
to
207415e
Compare
mikkeloscar
commented
Nov 1, 2024
| @@ -666,9 +623,6 @@ Resources: | |||
| GroupId: !Ref WorkerSecurityGroup | |||
| IpProtocol: tcp | |||
| SourceSecurityGroupId: !Ref MasterSecurityGroup | |||
| Tags: | |||
| - Key: 'kubernetes.io/cluster/{{.Cluster.ID}}' | |||
| Value: owned | |||
There was a problem hiding this comment.
All these cases are dropped because we set the tag at stack level already
mikkeloscar
force-pushed
the
eks-fix-cluster-tag
branch
from
207415e
to
a935713
Compare
|
👍 |
demonCoder95
reviewed
Nov 1, 2024
demonCoder95
reviewed
Nov 1, 2024
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the correct cluster on EKS which is
kubernetes.io/cluster/<eks-cluster-name>: owned. This fixes support for Service Type LoadBalancer because the EKS cloud-controller-manager was not able to find and attach nodes as they had the wrong cluster tag.This is a bit messy because we use
kubernetes.io/cluster/<cluster-id>on non-EKS andkubernetes.io/cluster/<eks-cluster-name>on EKS. So right now it's adding both tags on EKS to be compatible e.g. with e2e cleanup.I propose to create an internal tech-depth issue to discuss how to clean up this mess with cluster ID vs. Cluster Name.
Depends on