skipper: enable manual canary deployment #6592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
8 times, most recently
from
56b32e1
to
e139cdf
Compare
|
👍 |
mikkeloscar
reviewed
Nov 30, 2023
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
from
e139cdf
to
0e756ef
Compare
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
from
0e756ef
to
628bccf
Compare
szuecs
reviewed
Nov 30, 2023
szuecs
reviewed
Nov 30, 2023
szuecs
reviewed
Nov 30, 2023
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
3 times, most recently
from
36de8dc
to
115bf04
Compare
AlexanderYastrebov
added
the
architectural
szuecs
reviewed
Dec 1, 2023
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
from
115bf04
to
370d7ea
Compare
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
2 times, most recently
from
db14786
to
460eaed
Compare
szuecs
reviewed
Dec 4, 2023
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
from
460eaed
to
f8d32bc
Compare
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
4 times, most recently
from
cb2eee3
to
6a9c036
Compare
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
from
6a9c036
to
fe99cf0
Compare
The change introduces parameterized `skipper-ingress` deployment template. This template is used to define `main` and `canary` deployments. A single replica `canary` deployment is enabled by a new `skipper_ingress_canary_enabled` config item. When `canary` deployment is enabled number of `main` HPA min replicas is reduced by one. To deploy a canary version update `$canary_internal_version` and set `skipper_ingress_canary_enabled`. After checking that canary behaves as expected set `$internal_version` equal to `$canary_internal_version`. I.e. in the cluster where canary is enabled there is always one canary instance whose version is either above or equal to the main deployment version. All config items are accessed through `.Cluster.ConfigItems` for clarity. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
skipper/canary
branch
from
fe99cf0
to
9ef924c
Compare
szuecs
reviewed
Dec 5, 2023
| {{ end }} | ||
| resources: | ||
| {{ if and (eq .Cluster.ConfigItems.enable_dedicate_nodepool_skipper "true") (eq .Cluster.ConfigItems.skipper_ingress_binpack "true") }} | ||
| {{ $cpu_requests := sumQuantities .Cluster.ConfigItems.skipper_ingress_cpu (printf "-%s" .Cluster.ConfigItems.teapot_admission_controller_daemonset_reserved_cpu) (printf "-%s" .Cluster.ConfigItems.kubelet_system_reserved_cpu) (printf "-%s" .Cluster.ConfigItems.kubelet_kube_reserved_cpu) }} | ||
| {{ $cpu_requests := sumQuantities .Cluster.ConfigItems.skipper_ingress_cpu (printf "-%s" .Cluster.ConfigItems.teapot_admission_controller_daemonset_reserved_cpu) (printf "-%s" .Cluster.ConfigItems.kubelet_system_reserved_cpu) (printf "-%s" .Cluster.ConfigItems.kubelet_kube_reserved_cpu) }} |
There was a problem hiding this comment.
Oh I wasn't aware of that. So we can actually just set the configuration item to the resource of the node and this calculates the resources that can be used by skipper-ingress.
There was a problem hiding this comment.
This is only with skipper_ingress_binpack=true but this didn't work 100% so not enabled in most clusters yet. I was hoping to look into this with Karpenter as there seem to be a miscalculation with Cluster Autoscaler when I investigated it months ago.
|
👍 |
1 similar comment
|
👍 |
Merged
Merged
Merged
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 8, 2023
As we decided to not have a config item for canary version value it also does not make sense to have an item for canary args. This change uses template variable for canary args to keep canary version and args close together. Followup on #6592 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Dec 11, 2023
As we decided to not have a config item for canary version value it also does not make sense to have an item for canary args. This change uses template variable for canary args to keep canary version and args close together. Followup on #6592 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduces parameterized
skipper-ingressdeployment template.This template is used to define
mainandcanarydeployments.A single replica
canarydeployment is enabled by a newskipper_ingress_canary_enabledconfig item.When
canarydeployment is enabled number ofmainHPA min replicas is reduced by one.To deploy a canary version update
$canary_internal_versionand setskipper_ingress_canary_enabled.After checking that canary behaves as expected set
$internal_versionequal to$canary_internal_version.I.e. in the cluster where canary is enabled there is always one canary
instance whose version is either above or equal to the main deployment version.
All config items are accessed through
.Cluster.ConfigItemsfor clarity.architecturalNew features and architectural changes, e.g. framework changes, migrations, rollout of new services.