Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few performance improvements to compilation based on micro-optimizations / benchmarks -
body +=
seems to be faster than[].join("\n")
that is used by generate-function.string[][]
and avoid the unnecessary string manipulation. Reduces complexity - simplifies filtering of unwantedtrue
s and code generation.Next set of optimizations will follow in separate PRs.
Observations with this -
For a very big query (1100 lines formatted, 30+ fragments, 40+ variables, max depth - 8) that takes 1.7s to compile, this PR brings it down to around 1.4s - around 17% faster.