-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce configurable parameters for ES client node draining #407
Merged
otrosien
merged 13 commits into
zalando-incubator:master
from
A-Kamaee:node-drain-parametrization-2
May 16, 2024
Merged
Introduce configurable parameters for ES client node draining #407
otrosien
merged 13 commits into
zalando-incubator:master
from
A-Kamaee:node-drain-parametrization-2
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Kamaee
force-pushed
the
node-drain-parametrization-2
branch
3 times, most recently
from
April 29, 2024 08:42
45b2041
to
a76085e
Compare
otrosien
reviewed
Apr 29, 2024
A-Kamaee
force-pushed
the
node-drain-parametrization-2
branch
from
April 30, 2024 12:38
1e5a727
to
9551481
Compare
👍 |
mikkeloscar
reviewed
May 8, 2024
A-Kamaee
force-pushed
the
node-drain-parametrization-2
branch
3 times, most recently
from
May 14, 2024 09:14
d4bcfcd
to
ca4ffaa
Compare
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
…handle backward compatibility. Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
A-Kamaee
force-pushed
the
node-drain-parametrization-2
branch
from
May 14, 2024 13:10
ca4ffaa
to
b2e5752
Compare
I applied the changes you suggested, it would be nice if you can review and approve this PR. Thanks a lot. 🙏 |
👍 |
1 similar comment
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new configuration options to manage the draining of nodes in the Elasticsearch client
Description
Add new configuration options to manage the draining of nodes in the Elasticsearch client within the ES-operator project. These settings include the number of retries and the minimum and maximum wait times for retries, enhancing the flexibility and control over the node draining process.
-
elasticsearch-client-draining-retry
: Sets the number of retries for draining operations.-
elasticsearch-client-draining-min-wait-time
: Defines the minimum wait time between retry attempts.-
elasticsearch-client-draining-max-wait-time
: Specifies the maximum wait time between retry attempts.These parameters allow operators to tailor the draining behavior based on specific needs and conditions of their Elasticsearch clusters, ensuring more effective and reliable operations.
Types of Changes
Tasks
List of tasks you will do to complete the PR
Review