fix: register right navigation for dev tool only when console is enab…

…led (opensearch-project#6701) Signed-off-by: tygao <[email protected]>
yujin-emma · May 2, 2024 · b5121d3 · b5121d3
1 parent 1029884
commit b5121d3
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/src/plugins/dev_tools/public/plugin.ts b/src/plugins/dev_tools/public/plugin.ts
@@ -137,19 +137,21 @@ export class DevToolsPlugin implements Plugin<DevToolsSetup> {
   public start(core: CoreStart) {
     if (this.getSortedDevTools().length === 0) {
       this.appStateUpdater.next(() => ({ navLinkStatus: AppNavLinkStatus.hidden }));
+    } else {
+      // Register right navigation for dev tool only when console is enabled.
+      core.chrome.navControls.registerRight({
+        order: RightNavigationOrder.DevTool,
+        mount: toMountPoint(
+          React.createElement(RightNavigationButton, {
+            appId: this.id,
+            iconType: 'consoleApp',
+            title: this.title,
+            application: core.application,
+            http: core.http,
+          })
+        ),
+      });
     }
-    core.chrome.navControls.registerRight({
-      order: RightNavigationOrder.DevTool,
-      mount: toMountPoint(
-        React.createElement(RightNavigationButton, {
-          appId: this.id,
-          iconType: 'consoleApp',
-          title: this.title,
-          application: core.application,
-          http: core.http,
-        })
-      ),
-    });
   }
 
   public stop() {}