set PYOPENGL_PLATFORM before opengl imports #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishavlin
added
bug
matthewturk
approved these changes
Oct 28, 2024
|
|
||
| # PYOPENGL_PLATFORM must be set before any opengl imports | ||
| if engine in ("osmesa", "egl"): | ||
| os.environ["PYOPENGL_PLATFORM"] = engine |
There was a problem hiding this comment.
There's some distinction in how this sets the environment (like, not to parent process) that I think works in our favor. So, good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144 and also partly addresses #148 -- switching to headless rendering context now works as expected without having to manually set the PYOPENGL_PLATFORM environment variable.
I also switched how pytest sets PYOPENGL_PLATFORM since the monkeypatch was not having an effect (due to all the imports at the top of
test_yt_idv.py. pytest now runs for me locally without having to setPYOPENGL_PLATFORM.