Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: migrate requirement files to PEP 735 dependency groups #189

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

neutrinoceros
Copy link
Member

No description provided.

@neutrinoceros neutrinoceros force-pushed the dep/pep735_test_deps branch 2 times, most recently from 2ca26b9 to 17755b2 Compare October 30, 2024 09:30
@neutrinoceros
Copy link
Member Author

Run uv run --no-editable --compile-bytecode --group test --no-group typecheck --resolution=lowest-direct --exclude-newer '2022-03-27' \
  × No solution found when resolving dependencies:
  ╰─▶ Because cmyt:typecheck depends on matplotlib>=3.8 and only
      matplotlib<3.8 is available, we can conclude that cmyt:typecheck is
      incompatible.
      And because your project depends on cmyt:typecheck, we can conclude that
      your project's requirements are unsatisfiable.

      hint: Pre-releases are available for matplotlib in the requested
      range (e.g., 3.9.0rc2), but pre-releases weren't enabled (try:
      `--prerelease=allow`)

looks like a bug upstream in uv. Will report later.

@neutrinoceros
Copy link
Member Author

Hum actually, thinking a bit more about this, it doesn't seem like a bug in uv: uv run runs uv sync which always needs to look at all dependencies (extras an groups included) to ensure that the resolved environment stays compatible with a global lock file.
I see two ways to go about it:

  • keep a requirement file for typechecking for now
  • bite the bullet now and require matplotlib >= 3.8. This may feel a bit radical now but at the same time this package hasn't needed a release in a year and probably won't for the foreseeable future, so I think I'll run with it.

@neutrinoceros neutrinoceros added the dependencies Pull requests that update a dependency file label Oct 30, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review October 30, 2024 13:28
@neutrinoceros neutrinoceros merged commit d662988 into yt-project:main Oct 30, 2024
14 checks passed
@neutrinoceros neutrinoceros deleted the dep/pep735_test_deps branch October 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant