-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Elevation Gain #719
Open
ben-29
wants to merge
18
commits into
yihong0618:master
Choose a base branch
from
ben-29:feat-elevation-gain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Elevation Gain #719
+219
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refs/heads/upstream: (71 commits) Add laqieer's running page to README (yihong0618#672) chore: add raycast extension support (yihong0618#670) add </details> (yihong0618#669) fix the deprecation warning (yihong0618#668) Fix codoon and Upload tcx_to_garmin (yihong0618#662) Update README-CN.md (yihong0618#663) add keep2strava (yihong0618#653) Add data to 'running page runners' table (yihong0618#656) style: use Tailwind CSS (yihong0618#655) feat: fill country (yihong0618#654) docs: add runner (yihong0618#651) doc: add new runner docs: update README (yihong0618#650) docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644) fix: no package manager fix: tachyons-sass import error (yihong0618#639) Update README.md (yihong0618#638) Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634) chore: fix typo (yihong0618#633) chore: Update package manager and ignore requirements-dev.txt (yihong0618#632) ... # Conflicts: # run_page/gpxtrackposter/track.py # run_page/keep_sync.py
* refs/heads/upstream: feat: fix nrc Changed their apis (yihong0618#718) feat: conditionally output analysis JS only in Vercel environment (yihong0618#715) ignore the year which has no running data when drawing github.svg (yihong0618#712) Fix AttributeError in Activity class (yihong0618#714) doc: fix typo close yihong0618#704 Some Front Optimization for Keep indoor data (yihong0618#709) Add new runner (yihong0618#707) feat: adding illustration for special tracks (yihong0618#705) # Conflicts: # run_page/generator/__init__.py # run_page/joyrun_sync.py
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Will take a look later since it seems a break change. Let make it to version 2.5 |
Sounds Great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an
Elevation Gain
field to theActivity
model, per #509, Ideal for trail runners and hikers.Elevation Gain
field to the database and include a database update script.Elevation Gain
data from all sources, including Keep, Codoon, Joyrun, Nike, and others.Elevation Gain
data from GPX, TCX, and FIT files.Elevation Gain
field to the run table. switch:SHOW_ELEVATION_GAIN
(default: false)notice: For users who forked the project before this update, please run
python run_page/db_updater.py
to update the database.ps:
Elevation Gain
may be inaccurate. You can use Strava's "Correct Elevation" or Garmin's "Elev Corrections" feature for more precise data.(workouts_page) preview with
SHOW_ELEVATION_GAIN
= true