-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yew-router: Dynamic basename. #3725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnbear
force-pushed
the
dynamic_basename_2
branch
from
September 12, 2024 21:17
0eb58be
to
5bcfd0e
Compare
finnbear
changed the title
yew-router: Allow basename to change.
yew-router: Dynamic basename.
Sep 12, 2024
finnbear
commented
Sep 12, 2024
ranile
reviewed
Sep 19, 2024
ranile
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change. I have just one more concern here. Other than that, it looks good.
ranile
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
basename
changes, the URL isn't updated and the oldbasename
is persisted until the next navigation. With this PR,basename
changes take effect immediately.basename
is initiallySome
, the URL may lack thebasename
until the next nagvigation. With this PR, thebasename
is immediately added to the URL.Motivation
In my application, base path is used for something resembling a workspace while route is used for something resembling a page id with parameters. The base path may not exist (the default 'workspace') or may change (when moving between 'workspaces').
Checklist
added testsmodified existing test to test all new functionality