Add support for Django 4.X #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7532638881
💛 - Coveralls |
nichaydel
reviewed
Jan 16, 2024
nichaydel
reviewed
Jan 16, 2024
| django-version: [ "3.2" , "4.0", "4.1", "4.2"] | ||
| include: | ||
| - python-version: "3.10" | ||
| django-version: "5.0" |
There was a problem hiding this comment.
Any reason this is 5.0 vs one of the supported django-versions?
There was a problem hiding this comment.
Django 5.0 only supports Python 3.10 and above. That's why I added it as an include
nichaydel
reviewed
Jan 16, 2024
| @@ -1,4 +1,4 @@ | |||
| # Core packages needed | |||
| Django>=3.2, <4.0 | |||
| Django>=3.2, <6.0 | |||
There was a problem hiding this comment.
Is there a reason this is 6.0 as opposed to the highest supported version?
There was a problem hiding this comment.
The highest version currently is 5.0. I want to make the package ready for the 5.X upgrade, so the next person that needs to update Django doesn't have any issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for Django
4.0,4.1, and4.2How to test