Switch pcsclite dependency from cgo to native go

[mtibben]

Switch out the pcsclite cgo dependency to a native go dependency.

Please note I don't have a Yubikey, so it would be great to confirm that this works :)

[j0hnsmith]

Doesn't work on my mac because it seems that osx doesn't have a traditional PCSC unix socket any more gballet/go-libpcsclite@2772fd8

[yawn]

So this would be Linux only? What's the advantage of this approach in general?

[j0hnsmith]

@yawn see the linked pull request. @mtibben is trying to avoid ykoath requiring CGO=1 but he doesn't have a yubikey to test, he coded what looked like it would work.

I'm going to spend some time to try to get this working.

[mtibben]

Looks like it might be complicated on macOS... see https://ludovicrousseau.blogspot.com/search/label/Mac%20OS%20X

CryptoTokenKit is the closed-source Apple library, and looks like PC/SC API is implemented on top?

[mtibben]

Also https://ludovicrousseau.blogspot.com/2014/03/level-1-smart-card-support-on-mac-os-x.html

[yawn]

Maybe we should offer two versions - Darwin + everything else w/o CGO? Would this fit better?

[yawn]

Do you thing multiple builds would work here @j0hnsmith ?

[j0hnsmith]

Generally speaking, it's nice to be able to have CGO=0 as much as possible, however I'm not sure it would work for aws-vault as I suspect they would want the functionality for all architectures or none at all.

[yawn]

So this basically depends on gballet/go-libpcsclite#3 or any other cross OS solution like it.

[yawn]

Is this still something you depend on @j0hnsmith / @mtibben? If so, can we try to make some progress here? If the issue here is the missing Yubikey, I can send you one via Amazon ...

[j0hnsmith]

I'm pretty sure there is no cross platform solution available at this time. Also, aws-vault doesn't want native yubikey functionality, it prefers external solutions such as ykman.

IMO this can be closed.

[mtibben]

It's not that a native solution isn't wanted, it's that there is no simple cross-platform way to implement. We can close this