Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-22484: The alternative for the home link on the logo does not mean anything #3510

Merged
merged 6 commits into from
Nov 6, 2024
Merged

XWIKI-22484: The alternative for the home link on the logo does not mean anything #3510

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f2b4df3
XWIKI-22484: The alternative for the home link on the logo does not m…
Sereza7 Sep 19, 2024
a7411b8
XWIKI-22484: The alternative for the home link on the logo does not m…
Sereza7 Oct 23, 2024
34c40f8
XWIKI-22484: The alternative for the home link on the logo does not m…
Sereza7 Oct 23, 2024
defdf3d
XWIKI-22484: The alternative for the home link on the logo does not m…
Sereza7 Oct 23, 2024
5ea7a7e
Merge branch 'xwiki:master' into XWIKI-22484
Sereza7 Nov 6, 2024
a5ca06b
XWIKI-22484: The alternative for the home link on the logo does not m…
Sereza7 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...go-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/companylogo.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@
#end
#end
<div id="companylogo">
<a href="$!xwiki.getURL($services.wiki.currentWikiDescriptor.mainPageReference)" title="Home" rel="home" #if(!$displayPageHeader)class="navbar-brand"#end>
<img src="$!logourl" alt="Wiki Logo"/>
<a href="$!xwiki.getURL($services.wiki.currentWikiDescriptor.mainPageReference)" rel="home" ##
title="$escapetool.xml($services.localization.render('core.document.header.companylogo.logo.text'))" ##
#if(!$displayPageHeader)class="navbar-brand"#end>##
<span class="sr-only">$services.localization.render('core.document.header.companylogo.anchor.text')</span>
<img src="$!logourl" ##
alt="$escapetool.xml($services.localization.render('core.document.header.companylogo.logo.text'))"/>##
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These translation keys don't match those that are defined in the translation file below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in a5ca06b 👍
Thank you :)

</a>
</div>
3 changes: 3 additions & 0 deletions ...i-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,9 @@ core.footer.modification=Last modified by {0} on {1}
## This label is only visible by AT users to help with understanding the meaning of the top section containing
## the page title and the info about the last modification of the page.
core.document.header.info.label=Page header
## These two text alternatives are only visible by AT users.
core.document.header.logo.anchor.text=Home
core.document.header.logo.image.text=Logo of the wiki
## This label is only visible by AT users to help with understanding the meaning of the top section containing
## the action buttons: 'Edit', 'Create' and 'More Actions'.
core.document.header.menu.nav.label=Page actions
Expand Down