Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve element replicas in FloorPlot #9

Merged
merged 6 commits into from
Sep 14, 2024

Conversation

giadarol
Copy link
Member

Changes:

  • Resolve element replicas in FloorPlot

@giadarol giadarol requested a review from eltos September 14, 2024 07:36
@giadarol
Copy link
Member Author

I also added a requirement for the version of pint as users reported that that xplt stopped working after upgrading to numpy 2.0 (even reinstalling xplt did not help as pint was not updated).

Present version of pint does not support python 3.8 so I had to remove it from the test workflow.

@eltos
Copy link
Member

eltos commented Sep 14, 2024

Thank you, @giadarol

If you don't mind, I'd like to separate the Numpy 2 compatibility change on a separate PR, so we can have xplt 0.9 release pinned with everything numpy<2 and dedicated 0.10 release for numpy>=2

EDIT: See #10

@eltos eltos merged commit afa8a87 into xsuite:main Sep 14, 2024
6 checks passed
@giadarol
Copy link
Member Author

giadarol commented Sep 14, 2024

Thank you @eltos
Thant is perfect for me.
Would you like to make the releases or you prefer that we do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants