Implement progressive call invocations #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
om26er
requested changes
Oct 14, 2024
acceptor.go
Outdated
Comment on lines
24
to
25
| "progressive_call_invocations": true, | ||
| "call_canceling": true, |
There was a problem hiding this comment.
these two should be constants that are referred here
joiner.go
Outdated
Comment on lines
20
to
22
| "progressive_call_invocations": true, | ||
| "progressive_call_results": true, | ||
| "call_canceling": true, |
There was a problem hiding this comment.
please use constants for these as well. They should be in dealer/broker code
muzzammilshahid
force-pushed
the
progressive-call-invocation
branch
from
489fa35
to
4d02022
Compare
om26er
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.