Implement progressive call results #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzzammilshahid
force-pushed
the
progressive-call-results
branch
2 times, most recently
from
864150b
to
2c47c93
Compare
om26er
reviewed
Sep 10, 2024
messages/validator.go
Outdated
| @@ -302,7 +306,10 @@ func AsInt64(i interface{}) (int64, bool) { | |||
| case int32: | |||
| return int64(v), true | |||
| case uint: | |||
| return int64(v), true | |||
| if v > math.MaxInt64 { | |||
muzzammilshahid
force-pushed
the
progressive-call-results
branch
from
2c47c93
to
f5ab68f
Compare
muzzammilshahid
force-pushed
the
progressive-call-results
branch
from
f5ab68f
to
9d6a7a1
Compare
om26er
requested changes
Sep 19, 2024
dealer.go
Outdated
| @@ -108,19 +113,28 @@ func (d *Dealer) ReceiveMessage(sessionID int64, msg messages.Message) (*Message | |||
| break | |||
| } | |||
|
|
|||
| receiveProgress, ok := call.Options()[OptionReceiveProgress].(bool) | |||
| if !ok { | |||
There was a problem hiding this comment.
this check can be removed and the value of receiveProgress maybe used directly without reassining.
Suggested change
| if !ok { | |
| if !ok { |
dealer.go
Outdated
| @@ -131,13 +145,23 @@ func (d *Dealer) ReceiveMessage(sessionID int64, msg messages.Message) (*Message | |||
| return nil, fmt.Errorf("yield: not pending calls for session %d", sessionID) | |||
| } | |||
|
|
|||
| delete(d.pendingCalls, yield.RequestID()) | |||
| progress, ok := yield.Options()[OptionProgress].(bool) | |||
| if !ok { | |||
There was a problem hiding this comment.
same here, we can avoid the reassigning
session.go
Outdated
| @@ -60,7 +60,10 @@ func (w *Session) SendMessage(msg messages.Message) ([]byte, error) { | |||
| return data, nil | |||
| case messages.MessageTypeYield: | |||
| yield := msg.(*messages.Yield) | |||
| w.invocationRequests.Delete(yield.RequestID()) | |||
| progress, ok := yield.Options()[OptionProgress].(bool) | |||
| if !ok || !progress { | |||
There was a problem hiding this comment.
Suggested change
| if !ok || !progress { | |
| if !progress { |
should also work
session.go
Outdated
| if !exists { | ||
| return nil, fmt.Errorf("received RESULT for invalid requestID") | ||
| } | ||
|
|
||
| progress, ok := result.Details()[OptionProgress].(bool) | ||
| if !ok || !progress { |
There was a problem hiding this comment.
Suggested change
| if !ok || !progress { | |
| if !progress { |
try
muzzammilshahid
force-pushed
the
progressive-call-results
branch
from
9d6a7a1
to
6c573ce
Compare
muzzammilshahid
force-pushed
the
progressive-call-results
branch
from
6c573ce
to
a8b8455
Compare
om26er
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.