Maintenance: Remove isViewDidLoad, rework iPad corner info and detail view #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
changed the title
wutschel
force-pushed
the
rework_isviewdidload
branch
2 times, most recently
from
40345cb
to
29eeded
Compare
|
Causes trouble with collection view as "last mode" for a view. In this case the layout is not correctly done. |
wutschel
force-pushed
the
rework_isviewdidload
branch
from
29eeded
to
aca1440
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
from
aca1440
to
ae3edfd
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
2 times, most recently
from
83dd487
to
e90d3e7
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
3 times, most recently
from
79a96ab
to
bc0d5ed
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
2 times, most recently
from
f2e4c61
to
04d4445
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
3 times, most recently
from
982503e
to
6952e5e
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
3 times, most recently
from
63a25c0
to
36b484b
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
2 times, most recently
from
899ce33
to
95bb89b
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
2 times, most recently
from
127a0f8
to
74dc128
Compare
wutschel
force-pushed
the
rework_isviewdidload
branch
from
74dc128
to
44d832c
Compare
kambala-decapitator
approved these changes
Oct 27, 2024
|
Found a layout issue with this now, obviously was kept open for too long. Cannot merge and mark it as draft again. |
wutschel
force-pushed
the
rework_isviewdidload
branch
2 times, most recently
from
a81f1be
to
c88a131
Compare
Now iPad corner info only requires layout for iPad by adding a fixed space programmatically instead of adding it to xib and removing it for iPhone.
- Use descriptive ivar name - Simplify code inside condition check - Add detailed comment
wutschel
force-pushed
the
rework_isviewdidload
branch
from
c88a131
to
33898fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does some refactoring to simplify the state machine and logic.
isViewDidLoadin DetailViewController. Now iPad corner info only requires layout for iPad by adding a fixed space programmatically instead of adding it to xib and removing it for iPhone.isViewDidLoadin ShowInfoViewController. Now a check is done insidecreateInfoto only run the layout once.Summary for release notes
Maintenance: Remove isViewDidLoad, rework iPad corner info and detail view