Remove isViewDidLoad and replace by createInfo-internal check

xbmc · May 18, 2024 · 8337af1 · 8337af1
1 parent 308c100
commit 8337af1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/XBMC Remote/ShowInfoViewController.h b/XBMC Remote/ShowInfoViewController.h
@@ -82,7 +82,6 @@
     UIColor *foundTintColor;
     UILabel *viewTitle;
     __weak IBOutlet UIImageView *bottomShadow;
-    BOOL isViewDidLoad;
     UIImageView *isRecording;
     LogoBackgroundType logoBackgroundMode;
     UIBarButtonItem *doneButton;

diff --git a/XBMC Remote/ShowInfoViewController.m b/XBMC Remote/ShowInfoViewController.m
@@ -578,6 +578,10 @@ - (void)setIOS7barTintColor:(UIColor*)tintColor {
 }
 
 - (void)createInfo {
+    // Use mainLabel0 to check, if the info view already has been created
+    if (mainLabel0) {
+        return;
+    }
     // NEED TO BE OPTIMIZED. IT WORKS BUT THERE ARE TOO MANY IFS!
     NSMutableDictionary *item = self.detailItem;
     NSString *placeHolderImage = @"coverbox_back";
@@ -1874,10 +1878,7 @@ - (void)viewWillAppear:(BOOL)animated {
         viewTitle.textAlignment = NSTextAlignmentCenter;
         bottomShadow.hidden = YES;
     }
-    if (isViewDidLoad) {
-        [self createInfo];
-        isViewDidLoad = NO;
-    }
+    [self createInfo];
 }
 
 - (void)viewDidAppear:(BOOL)animated {
@@ -1949,7 +1950,6 @@ - (void)disableScrollsToTopPropertyOnAllSubviewsOf:(UIView*)view {
 
 - (void)viewDidLoad {
     [super viewDidLoad];
-    isViewDidLoad = YES;
     fanartView.tag = FANART_FULLSCREEN_DISABLE;
     fanartView.userInteractionEnabled = YES;
     UITapGestureRecognizer *touchOnKenView = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(showBackground:)];