Update to accommodate for new XTT changes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbild
suggested changes
Nov 30, 2018
There was a problem hiding this comment.
Glad to see these changes being made. Thanks!
Could you please split this into multiple commits:
- remove server id and expiry checks
- use XTT functions to read from NVRAM
- handle variable-length TLS certificates (unless the changes in commit 2 implicitly fix this as well).
I've some comments inline. In particular, I think the usages of xtt_read_object should be replaced with a new, higher-level API in XTT. I won't block merging of this PR while waiting on that, but we should discuss with Zane.
kathrynfejer
force-pushed
the
change-nvram-read
branch
from
033e3c5
to
87cbc46
Compare
drbild
approved these changes
Dec 4, 2018
drbild
suggested changes
Dec 4, 2018
There was a problem hiding this comment.
Code changes look good! Now we need to update the required version of XTT in CMakeLists.txt and README. That's blocked until @zanebeckwith cuts an XTT release with these changes.
|
Sorry for the delay @kathrynfejer. I've now released a new XTT (v0.10.1) |
kathrynfejer
force-pushed
the
change-nvram-read
branch
from
b9c6368
to
f4e60a4
Compare
drbild
suggested changes
Dec 12, 2018
kathrynfejer
force-pushed
the
change-nvram-read
branch
from
f4e60a4
to
b1f23a1
Compare
drbild
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will be necessary when XTT cuts a new release since the server_id and expiry have been taken out, and the NVRAM handles and functions for initializing the sapi and tcti contexts have been added to the XTT library.
This fixes #44 because the xaptum-tpm updates will allow us to read variable length data from NVRAM.