Improve claim integration test

wultra · Dec 7, 2023 · 356c588 · 356c588
1 parent cb0e438
commit 356c588
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 10 deletions.
diff --git a/WultraMobileTokenSDKTests/IntegrationProxy.swift b/WultraMobileTokenSDKTests/IntegrationProxy.swift
@@ -89,14 +89,15 @@ class IntegrationProxy {
         }
     }
 
-    func createNonPersonalisedOperation(_ factors: Factors = .F_2FA, completion: @escaping (NonPersonalisedOperationObject?) -> Void) {
+    func createNonPersonalisedPACOperation(_ factors: Factors = .F_2FA, completion: @escaping (NonPersonalisedTOTPOperationObject?) -> Void) {
         DispatchQueue.global().async {
             let opBody: String
             switch factors {
             case .F_2FA:
                 opBody = """
                 {
-                  "template": "login",
+                  "template": "login_preApproval",
+                  "proximityCheckEnabled": true,
                    "parameters": {
                      "party.id": "666",
                      "party.name": "Datová schránka",
@@ -111,6 +112,12 @@ class IntegrationProxy {
         }
     }
 
+    func getOperation(operation: NonPersonalisedTOTPOperationObject, completion: @escaping (NonPersonalisedTOTPOperationObject?) -> Void) {
+        DispatchQueue.global().async {
+            completion(self.makeRequest(url: URL(string: "\(self.config.cloudServerUrl)/v2/operations/\(operation.operationId)")!, body: "", httpMethod: "GET"))
+        }
+    }
+
     func getQROperation(operation: OperationObject, completion: @escaping (QROperationData?) -> Void) {
         DispatchQueue.global().async {
             completion(self.makeRequest(url: URL(string: "\(self.config.cloudServerUrl)/v2/operations/\(operation.operationId)/offline/qr?registrationId=\(self.registrationId)")!, body: "", httpMethod: "GET"))
@@ -266,14 +273,15 @@ struct OperationObject: Codable {
     let timestampExpires: Int
 }
 
-struct NonPersonalisedOperationObject: Codable {
+struct NonPersonalisedTOTPOperationObject: Codable {
     let operationId: String
     let status: String
     let operationType: String
     let failureCount: Int
     let maxFailureCount: Int
     let timestampCreated: Int
     let timestampExpires: Int
+    let proximityOtp: String?
 }
 
 private struct IntegrationConfig: Codable {

diff --git a/WultraMobileTokenSDKTests/IntegrationTests.swift b/WultraMobileTokenSDKTests/IntegrationTests.swift
@@ -95,7 +95,7 @@ class IntegrationTests: XCTestCase {
     func testDetail() {
         let exp = expectation(description: "Operation detail")
 
-        proxy.createNonPersonalisedOperation { op in
+        proxy.createNonPersonalisedPACOperation { op in
             if let op {
                 DispatchQueue.main.async {
                     _ = self.ops.getDetail(operationId: op.operationId) { result in
@@ -121,19 +121,47 @@ class IntegrationTests: XCTestCase {
     func testClaim() {
         let exp = expectation(description: "Operation Claim should return UserOperation with operation.id")
 
-        proxy.createNonPersonalisedOperation { op in
+        proxy.createNonPersonalisedPACOperation { op in
             if let op {
                 DispatchQueue.main.async {
                     _ = self.ops.claim(operationId: op.operationId) { result in
                         switch result {
                         case .success(let operation):
-                            XCTAssertEqual(op.operationId, operation.id)
-                        case .failure(let err):
-                            XCTFail(err.description)
+                            if operation.ui?.preApprovalScreen?.type == .qr {
+                                self.proxy.getOperation(operation: op) { totpOP in
+                                    XCTAssertNotNil(totpOP?.proximityOtp, "Even with proximityCheckEnabled: true, in proximityOtp nil")
+                                    if let totpOP = totpOP, let proximityOtp = totpOP.proximityOtp {
+                                        operation.proximityCheck = WMTProximityCheck(totp: proximityOtp, type: .qrCode)
+                                        //  wrong password on purpose
+                                        let auth = PowerAuthAuthentication.possessionWithPassword(password: "xxxx")
+                                        self.ops.authorize(operation: operation, with: auth) { result in
+                                            switch result {
+                                            case .failure:
+                                                let auth = PowerAuthAuthentication.possessionWithPassword(password: self.pin)
+                                                self.ops.authorize(operation: operation, with: auth) { result in
+                                                    if case .failure(let error) = result {
+                                                        XCTFail("Failed to authorize op: \(error.description)")
+                                                    }
+                                                    exp.fulfill()
+                                                }
+                                            case .success:
+                                                XCTFail("Operation approved with wrong password")
+                                                exp.fulfill()
+                                            }
+                                        }
+                                    } else {
+                                        XCTFail("Operation or TOTP is NIL")
+                                        exp.fulfill()
+                                    }
+                                }
+                            }
+
+                            case .failure(let err):
+                                XCTFail(err.description)
+                                exp.fulfill()
+                            }
                         }
-                        exp.fulfill()
                     }
-                }
             } else {
                 XCTFail("Failed to get operation detail")
                 exp.fulfill()