Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for claim-wise uniqueness validation #7106

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AfraHussaindeen
Copy link
Contributor

@AfraHussaindeen AfraHussaindeen commented Nov 11, 2024

Purpose

Introduce first-class support for attribute uniqueness validation.

Changes to the UI:

A new dropdown will be added to the attribute configuration section under the General tab, giving administrators the flexibility to define the scope of uniqueness validation for each attribute. The dropdown will offer three options:

  • None: No uniqueness validation.
  • Within Userstore: Validation applies only within the selected user store.
  • Across Userstores: Validation is enforced across all user stores.

Note : This dropdown will be displayed only when the uniqueness validation feature is enabled via the deployment.toml

[identity_mgt.user_claim_update.uniqueness]
enable = true

Related Issues

To be merged after

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@AfraHussaindeen AfraHussaindeen marked this pull request as draft November 11, 2024 09:59
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (f9090c4) to head (07df2e4).
Report is 161 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7106      +/-   ##
==========================================
+ Coverage   31.79%   32.02%   +0.22%     
==========================================
  Files          41       41              
  Lines         890      893       +3     
  Branches      220      220              
==========================================
+ Hits          283      286       +3     
+ Misses        607      557      -50     
- Partials        0       50      +50     
Flag Coverage Δ
@wso2is/core 32.02% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@AfraHussaindeen AfraHussaindeen force-pushed the attribute-uniqueness-feature branch 3 times, most recently from 30e8869 to 9da751d Compare November 12, 2024 07:34
@wso2-jenkins-bot
Copy link
Contributor

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants