Use x509 Authentication endpoint URL when configured #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpmadhavig
force-pushed
the
use-configured-x509-auth-url
branch
from
136a1c2
to
1dbc5cc
Compare
mpmadhavig
changed the title
AmshikaH
reviewed
Nov 21, 2023
...main/java/org/wso2/carbon/identity/authenticator/x509Certificate/X509CertificateServlet.java
Outdated
Show resolved
Hide resolved
...main/java/org/wso2/carbon/identity/authenticator/x509Certificate/X509CertificateServlet.java
Outdated
Show resolved
Hide resolved
Comment on lines
82
to
85
| if (port == -1) { | ||
| commonAuthURL = protocol + "://" + host + "/" + X509CertificateConstants.COMMON_AUTH; | ||
| } else { | ||
| commonAuthURL = protocol + "://" + host + ":" + port + "/" + X509CertificateConstants.COMMON_AUTH; |
There was a problem hiding this comment.
AFAIU the commonAuthURL will not contain the port number if the port is only -1. Can this port be a different minus value like -2, -3 etc. If so is it ok to add that to the URL?
There was a problem hiding this comment.
According to the documentation of java.net.URL getPort[1] method, Returns: the port number, or -1 if the port is not set.
[1] https://docs.oracle.com/javase/8/docs/api/java/net/URL.html#getPort--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves wso2/product-is#17484