Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a character validation for lastname and givenname claims #871

Open
wants to merge 1 commit into
base: 1.8.x
Choose a base branch
from
Open

Add a character validation for lastname and givenname claims #871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...y.recovery/src/main/java/org/wso2/carbon/identity/recovery/IdentityRecoveryConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ public class IdentityRecoveryConstants {
public static final String AP_CONFIRMATION_CODE_THREAD_LOCAL_INITIAL_VALUE =
"apConfirmationCodeThreadLocalInitialValue";

public static final String GIVENNAME_CLAIM = "http://wso2.org/claims/givenname";
public static final String LASTNAME_CLAIM = "http://wso2.org/claims/lastname";

private IdentityRecoveryConstants() {

}
Expand Down Expand Up @@ -284,6 +287,7 @@ public enum ErrorMessages {
ERROR_CODE_ERROR_DELETING_RECOVERY_DATA("20061", "Error deleting user recovery data of the tenant: %s"),
ERROR_CODE_ERROR_GETTING_CONNECTOR_CONFIG("20062", "Error while getting connector configurations"),
ERROR_CODE_ERROR_NO_REQUIRED_PERMISSIONS("20063", "User does not have required permissions"),
ERROR_CODE_INVALID_GIVEN_NAME_CLAIM("20067", "For security measures, < > ` \" characters are restricted"),

ERROR_CODE_ERROR_RETRIVING_CLAIM("18004", "Error when retrieving the locale claim of user '%s' of '%s' domain."),
ERROR_CODE_RECOVERY_DATA_NOT_FOUND_FOR_USER("18005", "Recovery data not found."),
Expand Down
8 changes: 8 additions & 0 deletions ...y/src/main/java/org/wso2/carbon/identity/recovery/signup/UserSelfRegistrationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,14 @@ public NotificationResponseBean registerUser(User user, String password, Claim[]
claimsMap.put(claim.getClaimUri(), claim.getValue());
}

String givenNameClaim = claimsMap.get(IdentityRecoveryConstants.GIVENNAME_CLAIM);
String lastNameClaim = claimsMap.get(IdentityRecoveryConstants.LASTNAME_CLAIM);
if ((StringUtils.isNotEmpty(givenNameClaim) && !Utils.isValidName(givenNameClaim)) ||
(StringUtils.isNotEmpty(lastNameClaim) && !Utils.isValidName(lastNameClaim))) {
throw Utils.handleClientException(IdentityRecoveryConstants.ErrorMessages.
ERROR_CODE_INVALID_GIVEN_NAME_CLAIM, null);
}

//Set arbitrary properties to use in UserSelfRegistrationHandler
Utils.setArbitraryProperties(properties);
validateAndFilterFromReceipt(consent, claimsMap);
Expand Down
11 changes: 11 additions & 0 deletions ....carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,4 +1356,15 @@ private static int getRecoveryCodeExpiryTime() {
return IdentityRecoveryConstants.RECOVERY_CODE_DEFAULT_EXPIRY_TIME;
}
}

/**
* Checks whether the user's name claims contain any of <, >, " and ` characters
*
* @param name username to validate
* @return true if any invalid character is found in the name
*/
public static boolean isValidName(String name) {

return !name.contains("<") && !name.contains(">") && !name.contains("\"") && !name.contains("`");
}
}