Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI]Update Integrate patch release #237

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Jan 22, 2024

This adds the ability to integrate patch release into the main apps.

It adds a host version flag (-V) to the release integrate command.

It will also fail if the trying to integrate a patch where the host version is not supplied.

NOTE: This will work for beta fixes but might not work for hot fixes where the release branch no longer exists. Issue to handle hotfixes #239

Testing

Follow the Testing guide to set up the tool to use forked repos.

Note: A patch PR is required on the forked Gutenberg Mobile repo before attempting the patch integration. This can be manually created to avoid requiring a Gutenberg patch PR

  • Create a release branch on the forked host apps e.g. release/1.0
  • Create a patch release PR on the Gutenberg Mobile fork
  • Run the integration command with the GBM patch version
  • Notice the failure message requiring a host version for an patch integration
  • Run the integration command again but now include the host version e.g. -V 1.0
  • The script should open a PR against the release branch

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The testing instructions passed. Please take note of the one suggestion I left regarding documentation.

@@ -59,5 +60,5 @@ Command used to check the status of any given release:
**Usage**

```
go run main.go release status 1.07.0
go run main.go release status 1.07.0
Copy link
Member

@dcalhoun dcalhoun Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me awhile to review this after failing miserably to succeed performing the testing instructions. Turns out, 1.07.0 is not a valid semver value! 😄

A leading zero is invalid. This caused the semver parsing to strip the preceding zero, which resulted in the CLI not locating the PR containing the preceding zero.

Suggested change
go run main.go release status 1.07.0
go run main.go release status 1.7.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh geez, sorry about that. TIL 1.0X.X is invalid

@jhnstn jhnstn merged commit 49c7972 into trunk Feb 23, 2024
2 checks passed
@jhnstn jhnstn deleted the update/integrate-patch-release branch February 23, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants