Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-commit hook for other repos to use #105

Merged
merged 1 commit into from
Nov 3, 2024
Merged

feat: pre-commit hook for other repos to use #105

merged 1 commit into from
Nov 3, 2024

Conversation

miketheman
Copy link
Collaborator

Depends on #104

@miketheman miketheman added documentation Improvements or additions to documentation enhancement New feature or request blocked packaging Packaging of zizmor in various ecosystems labels Nov 2, 2024

```yaml
- repo: https://github.com/woodruffw/zizmor
rev: v0.1.6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will only work after we push a new tag of this value, but I haven't tested that yet, I was using a local config to test in .pre-commit-config.yaml (not added to this scope):

repos:
- repo: local
  hooks:
  - id: zizmor
    name: zizmor
    language: rust
    files: \.github/workflows/.*\.yml$
    entry: ./target/release/zizmor

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense -- I can queue this into a release.

On a related note: it'd probably be nice to keep this rev: up-to-date automatically somehow, but I don't know of a good way to do that. Not a blocker, just something that came to mind 🙂

@miketheman miketheman removed the blocked label Nov 3, 2024
@miketheman miketheman marked this pull request as ready for review November 3, 2024 15:13
Copy link
Owner

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miketheman!

@woodruffw woodruffw merged commit b39da90 into main Nov 3, 2024
4 checks passed
@woodruffw woodruffw deleted the pre-commit branch November 3, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request packaging Packaging of zizmor in various ecosystems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants