Only split/explode the payment meta by ":" once #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some payment gateway (like Square) tokens include a ':' character in the token. When exporting payment gateway data we concat the key and meta value with a ':' (see example below) and so splitting the value by ':' resulted in only saving the first half of the token. This commit ensures we only explode/split the value once so the second half of the key is preserved. Example Square export value: "_wc_square_credit_card_payment_token:ccof:xyz|_wc_square_credit_card_customer_id:abc"
sun
approved these changes
May 5, 2023
| @@ -551,7 +551,8 @@ public static function set_payment_meta( $subscription, $data ) { | |||
|
|
|||
| if ( ! empty( $data[ self::$fields['payment_method_post_meta'] ] ) ) { | |||
| foreach ( explode( '|', $data[ self::$fields['payment_method_post_meta'] ] ) as $meta ) { | |||
| list( $name, $value ) = explode( ':', $meta ); | |||
| // Some payment gateway meta (like Square), includes a ':' in the token so limit the explode to only split once (2 values). | |||
There was a problem hiding this comment.
Suggested change
| // Some payment gateway meta (like Square), includes a ':' in the token so limit the explode to only split once (2 values). | |
| // Some payment gateway meta values contain a colon (e.g. Square token). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #221
Description:
Some payment gateway tokens, like Square, include a ':' character in the token itself. When exporting payment gateway data we concatenate the key and meta value with a ':' (see example below) and so splitting the value by ':' resulted in only saving the first half of the token.
This commit ensures we only explode/split the value once so the second half of the key is preserved.
Steps to test this PR:
masterthe resulting subscription's payment tokens will look like this: https://d.pr/i/xdBDRj